Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress NGINX: Promote controller & controller-chroot v1.11.0. #6947

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Ingress NGINX: Promote controller & controller-chroot v1.11.0. #6947

merged 2 commits into from
Jul 8, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jul 5, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2024
@Gacko
Copy link
Member Author

Gacko commented Jul 5, 2024

Google Cloud build log: https://storage.googleapis.com/kubernetes-jenkins/logs/post-ingress-nginx-push-images/1808959387054641152/artifacts/build.log

@strongjz
Copy link
Member

strongjz commented Jul 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2024
strongjz
strongjz approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@strongjz strongjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2024
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2024
@Gacko Gacko requested a review from strongjz July 8, 2024 11:49
@strongjz
Copy link
Member

strongjz commented Jul 8, 2024

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit e275934 into kubernetes:main Jul 8, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 8, 2024
@Gacko Gacko deleted the patch-2 branch July 8, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@Gacko @strongjz @k8s-ci-robot