Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create staging registry for aws-encryption-provider #7587

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Dec 6, 2024

Closes: #7439

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2024
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Dec 6, 2024
@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Plan Error

Show Output
running "/atlantis/bin/terraform1.6.5 init -input=false -upgrade" in "/atlantis/repos/kubernetes/k8s.io/7587/default/infra/gcp/terraform/k8s-staging-images": exit status 1

Initializing the backend...

Successfully configured the backend "gcs"! Terraform will automatically
use this backend unless the backend configuration changes.
Upgrading modules...
Downloading registry.terraform.io/GoogleCloudPlatform/artifact-registry/google 0.3.0 for artifact_registry...
- artifact_registry in .terraform/modules/artifact_registry
Downloading registry.terraform.io/terraform-google-modules/cloud-storage/google 8.0.3 for gcb_bucket...
- gcb_bucket in .terraform/modules/gcb_bucket/modules/simple_bucket
Downloading registry.terraform.io/terraform-google-modules/kms/google 3.2.0 for gcb_bucket.encryption_key...
- gcb_bucket.encryption_key in .terraform/modules/gcb_bucket.encryption_key
Downloading registry.terraform.io/terraform-google-modules/iam/google 8.0.0 for iam...
- iam in .terraform/modules/iam/modules/projects_iam
- iam.helper in .terraform/modules/iam/modules/helper
Downloading registry.terraform.io/terraform-google-modules/project-factory/google 14.5.0 for project...
- project in .terraform/modules/project
- project.budget in .terraform/modules/project/modules/budget
- project.essential_contacts in .terraform/modules/project/modules/essential_contacts
- project.gsuite_group in .terraform/modules/project/modules/gsuite_group
- project.project-factory in .terraform/modules/project/modules/core_project_factory
- project.project-factory.project_services in .terraform/modules/project/modules/project_services
- project.quotas in .terraform/modules/project/modules/quota_manager
- project.shared_vpc_access in .terraform/modules/project/modules/shared_vpc_access

Initializing provider plugins...
- Finding hashicorp/time versions matching ">= 0.5.0"...
- Finding hashicorp/null versions matching ">= 2.1.0"...
- Finding hashicorp/random versions matching ">= 2.2.0"...
- Finding hashicorp/google versions matching ">= 3.43.0, >= 3.53.0, >= 3.64.0, >= 4.28.0, >= 5.26.0, >= 5.31.0, ~> 5.34.0, >= 5.43.0, < 6.0.0, < 7.0.0"...
- Finding hashicorp/google-beta versions matching ">= 3.43.0, >= 3.64.0, >= 4.11.0, >= 4.28.0, >= 5.26.0, ~> 5.34.0, < 6.0.0, < 7.0.0"...
- Installing hashicorp/time v0.12.1...
- Installed hashicorp/time v0.12.1 (signed by HashiCorp)
- Installing hashicorp/null v3.2.3...
- Installed hashicorp/null v3.2.3 (signed by HashiCorp)
- Installing hashicorp/random v3.6.3...
- Installed hashicorp/random v3.6.3 (signed by HashiCorp)
- Installing hashicorp/google-beta v5.34.0...
- Installed hashicorp/google-beta v5.34.0 (signed by HashiCorp)
╷
│ Error: Failed to query available provider packages
│ 
│ Could not retrieve the list of available versions for provider
│ hashicorp/google: no available releases match the given constraints >=
│ 3.43.0, >= 3.53.0, >= 3.64.0, >= 4.28.0, >= 5.26.0, >= 5.31.0, ~> 5.34.0,
│ >= 5.43.0, < 6.0.0, < 7.0.0
╵


@upodroid upodroid added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 6, 2024
@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Show Output
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.artifact_registry["charts"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/charts"
        name                   = "charts"
      ~ update_time            = "2024-11-24T14:41:29.547209Z" -> "2024-12-06T15:33:54.572945Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["cloud-provider-kind"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/cloud-provider-kind"
        name                   = "cloud-provider-kind"
      ~ update_time            = "2024-11-12T22:55:13.890346Z" -> "2024-11-25T21:04:11.526859Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["csi-vsphere"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/csi-vsphere"
        name                   = "csi-vsphere"
      ~ update_time            = "2024-11-22T23:42:07.161211Z" -> "2024-12-05T20:52:14.327242Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["etcd-manager"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/etcd-manager"
        name                   = "etcd-manager"
      ~ update_time            = "2024-11-01T07:45:24.039084Z" -> "2024-12-02T21:07:31.873341Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["kueue"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/kueue"
        name                   = "kueue"
      ~ update_time            = "2024-11-24T14:43:20.016800Z" -> "2024-12-06T15:32:42.661798Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.gcb_bucket.google_storage_bucket.bucket has changed
~ resource "google_storage_bucket" "bucket" {
        id                          = "k8s-staging-images-gcb"
        name                        = "k8s-staging-images-gcb"
        # (16 unchanged attributes hidden)

      + hierarchical_namespace {
          + enabled = false
        }

        # (3 unchanged blocks hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place

Terraform will perform the following actions:

  # module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
      + cleanup_policy_dry_run = false
      + create_time            = (known after apply)
      + effective_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + format                 = "DOCKER"
      + id                     = (known after apply)
      + location               = "us-central1"
      + mode                   = "STANDARD_REPOSITORY"
      + name                   = (known after apply)
      + project                = "k8s-staging-images"
      + repository_id          = "aws-encryption-provider"
      + terraform_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + update_time            = (known after apply)

      + cleanup_policies {
          + action = "DELETE"
          + id     = "delete-images-older-than-90-days"

          + condition {
              + older_than            = "7776000s"
              + package_name_prefixes = []
              + tag_prefixes          = []
              + tag_state             = "ANY"
              + version_name_prefixes = []
            }
        }
    }

  # module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "allUsers"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.reader"
    }

  # module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-provider-aws@kubernetes.io"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "group:k8s-infra-staging-provider-aws@kubernetes.io"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.writer"
    }

  # module.artifact_registry["ingress-nginx"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
      + cleanup_policy_dry_run = false
      + create_time            = (known after apply)
      + effective_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + format                 = "DOCKER"
      + id                     = (known after apply)
      + location               = "us-central1"
      + mode                   = "STANDARD_REPOSITORY"
      + name                   = (known after apply)
      + project                = "k8s-staging-images"
      + repository_id          = "ingress-nginx"
      + terraform_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + update_time            = (known after apply)

      + cleanup_policies {
          + action = "DELETE"
          + id     = "delete-images-older-than-90-days"

          + condition {
              + older_than            = "7776000s"
              + package_name_prefixes = []
              + tag_prefixes          = []
              + tag_state             = "ANY"
              + version_name_prefixes = []
            }
        }
    }

  # module.artifact_registry["ingress-nginx"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "allUsers"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.reader"
    }

  # module.artifact_registry["ingress-nginx"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-ingress-nginx@kubernetes.io"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "group:k8s-infra-staging-ingress-nginx@kubernetes.io"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.writer"
    }

  # module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"] will be updated in-place
~ resource "google_project_iam_binding" "project_iam_authoritative" {
        id      = "k8s-staging-images/roles/viewer"
      ~ members = [
          + "group:k8s-infra-staging-ingress-nginx@kubernetes.io",
          + "group:k8s-infra-staging-provider-aws@kubernetes.io",
            # (9 unchanged elements hidden)
        ]
        # (3 unchanged attributes hidden)
    }

Plan: 6 to add, 1 to change, 0 to destroy.
  • ▶️ To apply this plan, comment:
    atlantis apply -d infra/gcp/terraform/k8s-staging-images
  • 🚮 To delete this plan and lock, click here
  • 🔁 To plan this project again, comment:
    atlantis plan -d infra/gcp/terraform/k8s-staging-images

Note: Objects have changed outside of Terraform
Plan: 6 to add, 1 to change, 0 to destroy.


  • ⏩ To apply all unapplied plans from this Pull Request, comment:
    atlantis apply
  • 🚮 To delete all plans and locks from this Pull Request, comment:
    atlantis unlock

@dims
Copy link
Member

dims commented Dec 6, 2024

/approve
/lgtm
/hold

please free to remove hold when ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member Author

upodroid commented Dec 6, 2024

atlantis apply
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@upodroid
Copy link
Member Author

upodroid commented Dec 6, 2024

atlantis apply

@k8s-infra-ci-robot
Copy link
Contributor

Ran Apply for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Show Output
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository.repo: Creating...
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository.repo: Creating...
module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"]: Modifying... [id=k8s-staging-images/roles/viewer]
module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"]: Modifications complete after 7s [id=k8s-staging-images/roles/viewer]
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository.repo: Still creating... [10s elapsed]
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository.repo: Still creating... [10s elapsed]
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository.repo: Creation complete after 12s [id=projects/k8s-staging-images/locations/us-central1/repositories/aws-encryption-provider]
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository.repo: Creation complete after 12s [id=projects/k8s-staging-images/locations/us-central1/repositories/ingress-nginx]
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creating...
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creating...
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-ingress-nginx@kubernetes.io"]: Creating...
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-provider-aws@kubernetes.io"]: Creating...
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creation complete after 4s [id=projects/k8s-staging-images/locations/us-central1/repositories/ingress-nginx/roles/artifactregistry.reader/allUsers]
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository_iam_member.readers["allUsers"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/aws-encryption-provider/roles/artifactregistry.reader/allUsers]
module.artifact_registry["ingress-nginx"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-ingress-nginx@kubernetes.io"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/ingress-nginx/roles/artifactregistry.writer/group:k8s-infra-staging-ingress-nginx@kubernetes.io]
module.artifact_registry["aws-encryption-provider"].google_artifact_registry_repository_iam_member.writers["group:k8s-infra-staging-provider-aws@kubernetes.io"]: Creation complete after 8s [id=projects/k8s-staging-images/locations/us-central1/repositories/aws-encryption-provider/roles/artifactregistry.writer/group:k8s-infra-staging-provider-aws@kubernetes.io]

Apply complete! Resources: 6 added, 1 changed, 0 destroyed.

@k8s-ci-robot k8s-ci-robot merged commit 1561cd9 into kubernetes:main Dec 6, 2024
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Dec 6, 2024
@k8s-infra-ci-robot
Copy link
Contributor

Locks and plans deleted for the projects and workspaces modified in this pull request:

  • dir: infra/gcp/terraform/k8s-staging-images workspace: default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants