Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove perf-dash-canary.k8s.io subdomain #777

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Remove perf-dash-canary.k8s.io subdomain #777

merged 1 commit into from
Apr 21, 2020

Conversation

bartsmykla
Copy link
Contributor

Waiting for confirmation from @mm4tt or @wojtek-t everything works and we can remove perf-dash-canary.k8s.io

/hold
/cc @mm4tt @wojtek-t

ref. #549, #776

  • removed subdomain from perf-dash certificate manifest

Signed-off-by: Bart Smykla bsmykla@vmware.com

Removed perf-dash-canary.k8s.io subdomain
5cb1fc4 
+ removed subdomain from perf-dash certificate manifest

Signed-off-by: Bart Smykla <bsmykla@vmware.com>
@bartsmykla bartsmykla changed the title Removed perf-dash-canary.k8s.io subdomain Remove perf-dash-canary.k8s.io subdomain Apr 21, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartsmykla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 21, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Apr 21, 2020

/lgtm

@mm4tt
Copy link
Contributor

mm4tt commented Apr 21, 2020

Everything works, feel free to proceed.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2020
@bartsmykla
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2d39e79 into kubernetes:master Apr 21, 2020
@bartsmykla bartsmykla deleted the remove-perf-dash-canary-dns branch April 21, 2020 17:04
@bartsmykla
Copy link
Contributor Author

DNS were reconcilled and new certificate.yaml applied to the cluster

@bartsmykla bartsmykla mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt Awaiting requested review from mm4tt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartsmykla @k8s-ci-robot @mm4tt