Update audit as of 2020-04-27 #807
Conversation
remove groups from projectViewer role
... mea culpa, I accidentally nuked kubernetes-public's project-wide ssh-keys metadata, dims will need to re-add
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/audit
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "serviceAccount:kubernetes-public.svc.id.goog[test-pods/boskos-janitor]" |
There was a problem hiding this comment.
Why is it still called "test-pods"
| @@ -1,22 +1,22 @@ | |||
| { | |||
| "commonInstanceMetadata": { | |||
| "fingerprint": "9_em4FUS_lU=", | |||
There was a problem hiding this comment.
Another candidate for being removed @bartsmykla
| { | ||
| "createTime": "2020-04-26T17:09:06.114Z", | ||
| "lifecycleState": "ACTIVE", | ||
| "name": "spiffxp-boskos-project-01", |
There was a problem hiding this comment.
Let's not forget to clean these up :)
There was a problem hiding this comment.
this is exactly why I put my name on them
|
/close |
|
@spiffxp: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was intended to pick up the results of running scripts/terraform introduced in #806
It also picked up:
projectViewpermissions onk8s-conformbucketskubernetes-publicproject-widessh-keysmetadataspiffxp-node-e2e-projectbut forgot the--projectflag and was defaulted tokubernetes-public2020-01-28/cc @dims
to ack the ssh-keys removal
/cc @thockin @bartsmykla @cblecker
whomever is interested in reviewing the audit