Add oncall groups and bind to projective primitive roles #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-infra-oncall and scalability-oncall are both used to having owner access to the projects they administer today, so that's what I went with
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/access
k8s-ci-robot
added
wg/k8s-infra
approved
|
/cc @BenTheElder |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
ran working on the rest... |
|
ran find a typo (ref: #922) so edited locally to workaround ran |
tosi3k
added a commit
to tosi3k/k8s.io
that referenced
this pull request
Jul 22, 2020
Adding myself to k8s-infra-sig-scalability-oncall@kubernetes.io and k8s-infra-rbac-perfdash@kubernetes.io groups. Ref: kubernetes#919 /cc wojtek-t
spiffxp
added
the
area/prow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors what is done today for the google.com-equivalent projects
I also added a k8s-infra-prow-viewer group to see if that would give sufficient
access for troubleshooting
I anticipate dialing these down to custom roles to be done as followup
ACLs ref: #844
scalability ref: kubernetes/test-infra#17725