kubernetes-csi: promote first multi-arch mock-driver release #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @msau42 |
pohly
force-pushed
the
promote-multiarch-mock-driver
branch
from
bd658da to
3ddf6d8
Compare
k8s-ci-robot
added
size/S
|
The OWNERS file should have been in the previous PR #934 but I accidentally dropped it while reworking that PR. Now we need approval from one of the repo owners one more (and hopefully then the last) time. |
msau42
reviewed
Jun 4, 2020
k8s.gcr.io/images/OWNERS
Outdated
| @@ -0,0 +1,9 @@ | |||
| # See the OWNERS docs at https://go.k8s.io/owners | |||
There was a problem hiding this comment.
should this be one level down in "k8s-staging-csi"?
csi-test v3.1.1 produced the first multi-arch image. We probably want to promote only the combined image (tag: v3.1.1) and not the individual ones for each architecture (tags: amd64-linux-v3.1.1, ppc64le-linux-v3.1.1, s390x-linux-v3.1.1). This showed that the `tags~` regex matching does a sub-string match and not a full match, so the script gets updated a bit to simplify some terms and tighten the one that matches versions.
pohly
force-pushed
the
promote-multiarch-mock-driver
branch
from
3ddf6d8 to
1d7d651
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csi-test v3.1.1 produced the first multi-arch image. We probably want
to promote only the combined image (tag: v3.1.1) and not the
individual ones for each architecture (tags: amd64-linux-v3.1.1,
ppc64le-linux-v3.1.1, s390x-linux-v3.1.1).
This showed that the
tags~regex matching does a sub-string matchand not a full match, so the script gets updated a bit to simplify
some terms and tighten the one that matches versions.
/cc @msau42