forked from golang/glog
-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
contextual logging: avoid extra SetContextualLogger API
We can avoid the variant of SetLogger by indicating support via an additional interface that the LogSink must implement. This was seen as a cleaner approach (#296 (comment)).
- Loading branch information
Showing
2 changed files
with
79 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
Copyright 2022 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package klog_test | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/go-logr/logr" | ||
"k8s.io/klog/v2" | ||
) | ||
|
||
func ExampleSetLogger() { | ||
logger := logr.Discard() | ||
klog.SetLogger(logger) | ||
equal := logger == klog.Background() | ||
fmt.Printf("original logr.Discard logger can be used directly: %v\n", equal) | ||
|
||
logger = klog.AddSupportsContext(logger) | ||
klog.SetLogger(logger) | ||
equal = logger == klog.Background() | ||
fmt.Printf("wrapped logger can be used directly: %v\n", equal) | ||
|
||
// Output: | ||
// original logr.Discard logger can be used directly: false | ||
// wrapped logger can be used directly: true | ||
} |