forked from golang/glog
-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit fixes issues with Windows integration tests and enables the tests to run through github. The problem was that the tests using the log_dir option expected symlinks to the log files to exist, those symlinks being (main.INFO, main.WARN, etc). This was a problem for two reasons: 1) On Windows the symlinks would start with main.exe, not just main 2) The creation of symlinks is not guarenteed on any platform, and on Windows creating a symlink requires Administrator permissions. This was fixed by changing the tests to search for either the symlinks (with a fixed filepath), or the log files themselves. Future work can be done to deal with the lack of symlinks on Windows, but this commit's purpose is to get tests in a passing state.
- Loading branch information
Showing
2 changed files
with
51 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters