Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement klog.KObj klog.KRef functions #127

Closed
serathius opened this issue Mar 19, 2020 · 3 comments · Fixed by #128
Closed

Implement klog.KObj klog.KRef functions #127

serathius opened this issue Mar 19, 2020 · 3 comments · Fixed by #128
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.

Comments

@serathius
Copy link

/kind feature

Describe the solution you'd like
Klog should implement standard klog.KObj and klog.KRef functions needed for referencing kubernetes objects.

func KObj(obj ObjectMeta) ObjectRef
func KRef(namespace, name string) ObjectRef

type ObjectRef struct {
  Name      string `json:"name"`
  Namespace string `json:"namespace,omitempty"`
}

Specifications are described within KEP

Anything else you would like to add:
Part of Structured Logging effort kubernetes/enhancements#1602
/help
/priority important-soon
/sig instrumentation
/milestone v1.19

@k8s-ci-robot
Copy link

@serathius:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind feature

Describe the solution you'd like
Klog should implement standard klog.KObj and klog.KRef functions needed for referencing kubernetes objects.

func KObj(obj ObjectMeta) ObjectRef
func KRef(namespace, name string) ObjectRef

type ObjectRef struct {
 Name      string `json:"name"`
 Namespace string `json:"namespace,omitempty"`
}

Specifications are described within KEP

Anything else you would like to add:
Part of Structured Logging effort kubernetes/enhancements#1602
/help
/priority important-soon
/sig instrumentation
/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 19, 2020
@tahsinrahman
Copy link

/assign

@serathius
Copy link
Author

serathius commented Mar 24, 2020

Awesome @tahsinrahman thanks for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants