-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logr has tagged v1.0.0-rc1 #241
Comments
looks like the diff for logr is as shown here: go-logr/logr@v0.4.0...v1.0.0-rc1 |
/assign @dims |
go-logr/zapr#28 is a more surgical example (but I
did spend a log of time on the glogr changes to make perf less terrible,
e.g. avoiding `json`)
…On Sat, May 29, 2021 at 8:17 AM Davanum Srinivas ***@***.***> wrote:
/assign @dims <https://github.com/dims>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#241 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVGY77ZUFLGW4TSWRTTTQEAPZANCNFSM45XXMHTQ>
.
|
logr v1.0.0 has been tagged. No changes since rc1. |
Hi. Have a new release? |
v2.20.0 uses logr v1.1.0. /close |
@pohly: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
logr made BREAKING CHANGES for implementations to prep for 1.0.0
I know this impl was derived from glogr, so here's the glogr PR that adopts the new logr API changes: go-logr/glogr#13 - this includes a bunch of perf-related changes too.
The changes are not THAT complicated. Please feel free to shout if they don't make sense.
The text was updated successfully, but these errors were encountered: