-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging reference format with Group, Version, Kind, Namespace and Name #350
Comments
This might be a reasonable addition. What API did you have in mind for creating such a struct? |
Definitely open to advice on this 🙂. Would it be reasonable to add it to KRef in a backwards compatible way? Or could we add a new struct e.g. KResourceRef with the same semantics as logRef in Cluster API? |
We cannot change If you want to give it a try, feel free to prepare a PR. However, no promise that it then will really get merged. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Would still like to include this if we can get an agreement on the API over at #351 /reopen |
@killianmuldoon: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
/unassign I don't have time to drive this. |
/remove-lifecycle rotten |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
It would be useful to have klog reference format that includes all of the information about a resource required to identify it - i.e. Group, Version, Kind, Namespace and Name.
Would it be possible to add a type that holds all of this information (or to add fields to an existing type e.g. KRef)?
This ask comes from usage of klog in Cluster API where full references including kind etc. are needed for related objects e.g. the OwnerRef of the principle object. The struct would be useful as it allows correct logging of the full type information using both text and json logging.
This is what Cluster API has currently:
/kind feature
The text was updated successfully, but these errors were encountered: