text output: formatting of slice of pointers

[pohly]

/kind feature

Describe the solution you'd like

When the value in a key/value pair is a slice like []*v1.Pod, klog currently formats the slice with the fallback fmt.Sprintf("%+v", ...) which then results in a list of pointer values ([0xc000dce900]) which is often not useful. I would find it more useful to get a dump of the objects that are pointed to.

There are probably other cases like this, but list of objects is the one I have seen myself a few times.

[pohly]

@serathius : what do you think?

[pohly]

For backward compatibility we probably would have to print the pointer in addition to the object, because some users might expect that.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pohly]

/remove-lifecycle stale
/triage accepted

@serathius: what do you think about this? Would this be useful enough to justify some extra complexity?

[pohly]

#352 solves most of this. Falling back to JSON for a slice means that we don't support fmt.Stringer and logr.Marshaler implementations for the values inside the slices, but that is consistent with other go-logr backends.

[pohly]

#352 was merged, therefore I consider this issue resolved.

/close

[k8s-ci-robot]

@pohly: Closing this issue.

In response to this:

#352 was merged, therefore I consider this issue resolved.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.