-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text output: formatting of slice of pointers #352
Comments
@serathius : what do you think? |
For backward compatibility we probably would have to print the pointer in addition to the object, because some users might expect that. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale @serathius: what do you think about this? Would this be useful enough to justify some extra complexity? |
#352 solves most of this. Falling back to JSON for a slice means that we don't support |
#352 was merged, therefore I consider this issue resolved. /close |
@pohly: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
Describe the solution you'd like
When the value in a key/value pair is a slice like
[]*v1.Pod
, klog currently formats the slice with the fallbackfmt.Sprintf("%+v", ...)
which then results in a list of pointer values ([0xc000dce900]
) which is often not useful. I would find it more useful to get a dump of the objects that are pointed to.There are probably other cases like this, but list of objects is the one I have seen myself a few times.
The text was updated successfully, but these errors were encountered: