Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how errors are printed #134

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Conversation

benmoss
Copy link
Member

@benmoss benmoss commented Apr 8, 2020

What this PR does / why we need it:
Fixes how errors are printed. Previously the regular error type would be printed as {}.

Special notes for your reviewer:
https://play.golang.org/p/iynQRn87vVZ demonstrates the bug

Release note:

klogr will now print error types using their `Error()` method.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2020
@neolit123
Copy link
Member

TestRollover: klog_test.go:395: info wasn't created

i think this is a flake...
/retest

the change itself LGTM.

klogr/klogr.go Show resolved Hide resolved
@dims
Copy link
Member

dims commented Apr 9, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2020
@benmoss
Copy link
Member Author

benmoss commented Apr 9, 2020

Hmm, looks like something is broken with the combination of GitHub and Travis, the build is done there but GH still reports it as pending

@dims
Copy link
Member

dims commented Apr 9, 2020

/retest

@dims
Copy link
Member

dims commented Apr 9, 2020

/close

@k8s-ci-robot
Copy link

@dims: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Apr 9, 2020

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Apr 9, 2020
@k8s-ci-robot
Copy link

@dims: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
@benmoss
Copy link
Member Author

benmoss commented Apr 9, 2020

I just did a force push without changing anything to see if that fixes it

@benmoss
Copy link
Member Author

benmoss commented Apr 9, 2020

Ah, looks like the travis build is gone now

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, dims, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4cae117 into kubernetes:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants