Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ClearLogger #257

Merged
merged 1 commit into from
Aug 4, 2021
Merged

export ClearLogger #257

merged 1 commit into from
Aug 4, 2021

Conversation

pohly
Copy link

@pohly pohly commented Aug 4, 2021

What this PR does / why we need it:

Code in Kubernetes also needs the ability to unset a logger.

Release note:

ClearLogger can be used to remove a logger that was set previously with SetLogger.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2021
Code in Kubernetes also needs the ability to unset a logger.
@dims
Copy link
Member

dims commented Aug 4, 2021

/approve
/lgtm

As discussed on the slack thread yesterday:
https://kubernetes.slack.com/archives/CHGFYJVAN/p1628023746019200?thread_ts=1627926227.001800&cid=CHGFYJVAN

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 74b1b2a into kubernetes:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants