ktesting improvements #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, replacing normal klog text output with ktesting lost the time
stamps. This is perhaps not important for unit tests, but for benchmarking
those can be crucial.
Now ktesting uses a stripped down klog header:
- The source code location comes first, because
that is printed by the testing package.
- Instead if INFO and ERROR, the short I and E are used.
- The useless tid/pid part isn't present.
Example:
$ go test -v ./ktesting/example/
=== RUN TestKlogr
example_test.go:45: I0201 17:58:36.235936] hello world
example_test.go:46: E0201 17:58:36.236052] failed err="failed: some error"
example_test.go:47: I0201 17:58:36.236086] verbosity 1
example_test.go:48: I0201 17:58:36.236110] main/helper: with prefix
example_test.go:50: I0201 17:58:36.236154] key/value pairs int=1 float=2 pair="(1, 2)" raw={Name:joe NS:kube-system} kobj="kube-system/joe"
example_test.go:57: I0201 17:58:36.236187] info message level 4
example_test.go:58: I0201 17:58:36.236209] info message level 5
--- PASS: TestKlogr (0.00s)
PASS
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If klog contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
Most users won't need this feature. It was enabled by default to keep the API simple and because the primary goal was unit testing, but benchmarks also need this and there unnecessary overhead needs to be avoided.
pohly
force-pushed
the
ktesting-timestamps
branch
from
b036b2e
to
5f1d9ca
Compare
The intended usage is to replace fmt.Sprintf("%+v") with gomega.format.Object +
YAML support, therefore the only public API change is in the (still
experimental) ktesting.
Internally the additional function pointer gets passed through via a new
Formatter struct. To minimize the impact on klog and textlogger, the
package-level functions still exist and use an empty Formatter.
pohly
force-pushed
the
ktesting-timestamps
branch
from
5f1d9ca
to
1b27ee8
Compare
serathius
approved these changes
Feb 3, 2023
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This needs another force-merge because of the API diff in ktesting. /assign @dims |
|
I can force-merge if needed Looks like the issue is: |
TylerHelmuth
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Dec 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [k8s.io/klog](https://github.com/kubernetes/klog) | require | major | `v1.0.0` -> `v2.110.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes/klog (k8s.io/klog)</summary> ### [`v2.110.1`](https://github.com/kubernetes/klog/releases/tag/v2.110.1): Prepare klog release for Kubernetes v1.29 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.100.1...v2.110.1) #### What's Changed - fix: SetLogger via klog.SetLogger will output an unexpected newline by [@​aimuz](https://github.com/aimuz) in [https://github.com/kubernetes/klog/pull/378](https://github.com/kubernetes/klog/pull/378) - resolve comments warning by [@​lowang-bh](https://github.com/lowang-bh) in [https://github.com/kubernetes/klog/pull/379](https://github.com/kubernetes/klog/pull/379) - stderrthreshold: fix flag comment by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/376](https://github.com/kubernetes/klog/pull/376) - enable "go vet" checks for parameters by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/390](https://github.com/kubernetes/klog/pull/390) - promote experimental code to stable by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/392](https://github.com/kubernetes/klog/pull/392) - golangci-lint action by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/380](https://github.com/kubernetes/klog/pull/380) - output: handle WithName like zapr does by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/391](https://github.com/kubernetes/klog/pull/391) - slog support + logr 1.3.0 update by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/384](https://github.com/kubernetes/klog/pull/384) #### New Contributors - [@​aimuz](https://github.com/aimuz) made their first contribution in [https://github.com/kubernetes/klog/pull/378](https://github.com/kubernetes/klog/pull/378) - [@​lowang-bh](https://github.com/lowang-bh) made their first contribution in [https://github.com/kubernetes/klog/pull/379](https://github.com/kubernetes/klog/pull/379) **Full Changelog**: kubernetes/klog@v2.100.1...v2.110.1 ### [`v2.100.1`](https://github.com/kubernetes/klog/releases/tag/v2.100.1): Prepare klog release for Kubernetes v1.28 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.90.1...v2.100.1) #### What's Changed - expose logBridge via NewStandardLog() by [@​mikedanese](https://github.com/mikedanese) in [https://github.com/kubernetes/klog/pull/369](https://github.com/kubernetes/klog/pull/369) - add Format wrapper by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/374](https://github.com/kubernetes/klog/pull/374) - JSON as fallback encoding by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/375](https://github.com/kubernetes/klog/pull/375) #### New Contributors - [@​mikedanese](https://github.com/mikedanese) made their first contribution in [https://github.com/kubernetes/klog/pull/369](https://github.com/kubernetes/klog/pull/369) **Full Changelog**: kubernetes/klog@v2.90.1...v2.100.1 ### [`v2.90.1`](https://github.com/kubernetes/klog/releases/tag/v2.90.1): Prepare klog release for Kubernetes v1.27 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.90.0...v2.90.1) #### What's Changed - buffer: restore dropping of too large buffers by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/366](https://github.com/kubernetes/klog/pull/366) - ktesting improvements by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/365](https://github.com/kubernetes/klog/pull/365) - ktesting + textlogger config api by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/368](https://github.com/kubernetes/klog/pull/368) - textlogger write through by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/363](https://github.com/kubernetes/klog/pull/363) **Full Changelog**: kubernetes/klog@v2.90.0...v2.90.1 ### [`v2.90.0`](https://github.com/kubernetes/klog/releases/tag/v2.90.0): Prepare klog release for Kubernetes v1.27 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.80.1...v2.90.0) #### What's Changed - klog: benchmark the overhead when logging is off by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/355](https://github.com/kubernetes/klog/pull/355) - improve textlogger by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/362](https://github.com/kubernetes/klog/pull/362) **Full Changelog**: kubernetes/klog@v2.80.1...v2.90.0 ##### There are some API differences from previous version k8s.io/klog/v2/klogr contains incompatible changes: - klogger.Enabled: removed - klogger.Error: removed - klogger.Info: removed k8s.io/klog/v2/test contains incompatible changes: - InitKlog: changed from func() to func(testing.TB) *flag.FlagSet ### [`v2.80.1`](https://github.com/kubernetes/klog/releases/tag/v2.80.1): Prepare klog release for Kubernetes v1.26 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.80.0...v2.80.1) #### What's Changed - InitFlags concurrency fix by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/349](https://github.com/kubernetes/klog/pull/349) **Full Changelog**: kubernetes/klog@v2.80.0...v2.80.1 ### [`v2.80.0`](https://github.com/kubernetes/klog/releases/tag/v2.80.0): Prepare klog release for Kubernetes v1.26 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.70.1...v2.80.0) #### What's Changed - OWNERS: add harshanarayana by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/342](https://github.com/kubernetes/klog/pull/342) - kvlistformat: fix the issue with display marshalled value for non string type by [@​harshanarayana](https://github.com/harshanarayana) in [https://github.com/kubernetes/klog/pull/344](https://github.com/kubernetes/klog/pull/344) - Bump version of golang to 1.19 and drop older versions by [@​dims](https://github.com/dims) in [https://github.com/kubernetes/klog/pull/345](https://github.com/kubernetes/klog/pull/345) **Full Changelog**: kubernetes/klog@v2.70.1...v2.80.0 ### [`v2.70.1`](https://github.com/kubernetes/klog/releases/tag/v2.70.1): Prepare klog release for Kubernetes v1.25 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.70.0...v2.70.1) #### What's Changed - ktesting: handle test completion by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/337](https://github.com/kubernetes/klog/pull/337) - contextual logging: enable by default again by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/341](https://github.com/kubernetes/klog/pull/341) **Full Changelog**: kubernetes/klog@v2.70.0...v2.70.1 ### [`v2.70.0`](https://github.com/kubernetes/klog/releases/tag/v2.70.0): Prepare klog release for Kubernetes v1.25 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.60.1...v2.70.0) #### What's Changed - logcheck: contextual logging + enhanced checks by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/297](https://github.com/kubernetes/klog/pull/297) - hack/tools: drop dependency on golangci-lint by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/313](https://github.com/kubernetes/klog/pull/313) - StopFlushDaemon: document flushing on shutdown by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/314](https://github.com/kubernetes/klog/pull/314) - logcheck: fix detection of invalid \* regexp in filter by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/315](https://github.com/kubernetes/klog/pull/315) - README.md: clarify -logtostderr by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/319](https://github.com/kubernetes/klog/pull/319) - Trim duplicates by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/324](https://github.com/kubernetes/klog/pull/324) - replace KObjs with KObjSlice by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/322](https://github.com/kubernetes/klog/pull/322) - support logr.Marshaler by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/325](https://github.com/kubernetes/klog/pull/325) - internal: remove unused TrimDuplicates by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/326](https://github.com/kubernetes/klog/pull/326) - save and restore state by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/320](https://github.com/kubernetes/klog/pull/320) - GitHub: use apidiff with more recent Go by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/329](https://github.com/kubernetes/klog/pull/329) - remove hack/tools by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/330](https://github.com/kubernetes/klog/pull/330) - GIT-331: fix shadowing key from the kv pair by [@​harshanarayana](https://github.com/harshanarayana) in [https://github.com/kubernetes/klog/pull/332](https://github.com/kubernetes/klog/pull/332) - klog.Fatal backtrace revert by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/328](https://github.com/kubernetes/klog/pull/328) - ktesting: capture log data in memory by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/327](https://github.com/kubernetes/klog/pull/327) - GIT-275: add tests for int and struct keys by [@​harshanarayana](https://github.com/harshanarayana) in [https://github.com/kubernetes/klog/pull/333](https://github.com/kubernetes/klog/pull/333) #### New Contributors - [@​harshanarayana](https://github.com/harshanarayana) made their first contribution in [https://github.com/kubernetes/klog/pull/332](https://github.com/kubernetes/klog/pull/332) **Full Changelog**: kubernetes/klog@v2.60.1...v2.70.0 ### [`v2.60.1`](https://github.com/kubernetes/klog/releases/tag/v2.60.1): Prepare klog release for Kubernetes v1.24 (Take 6) [Compare Source](https://github.com/kubernetes/klog/compare/v2.60.0...v2.60.1) #### What's Changed - Cleanup OWNERS file by [@​serathius](https://github.com/serathius) in [https://github.com/kubernetes/klog/pull/309](https://github.com/kubernetes/klog/pull/309) - dependencies: avoid k8s.io/utils, fork clock code instead by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/310](https://github.com/kubernetes/klog/pull/310) - promote contextual logging APIs to stable by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/311](https://github.com/kubernetes/klog/pull/311) **Full Changelog**: kubernetes/klog@v2.60.0...v2.60.1 ### [`v2.60.0`](https://github.com/kubernetes/klog/releases/tag/v2.60.0): Prepare klog release for Kubernetes v1.24 (Take 5) [Compare Source](https://github.com/kubernetes/klog/compare/v2.50.2...v2.60.0) #### What's Changed - SetContextualLogger: remove unintentionally merged API call by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/308](https://github.com/kubernetes/klog/pull/308) **Full Changelog**: kubernetes/klog@v2.50.2...v2.60.0 ### [`v2.50.2`](https://github.com/kubernetes/klog/compare/v2.50.1...v2.50.2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.50.1...v2.50.2) ### [`v2.50.1`](https://github.com/kubernetes/klog/releases/tag/v2.50.1): Prepare klog release for Kubernetes v1.24 (Take 4) [Compare Source](https://github.com/kubernetes/klog/compare/v2.50.0...v2.50.1) #### What's Changed - SetLoggerWithOptions: support flushing by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/306](https://github.com/kubernetes/klog/pull/306) **Full Changelog**: kubernetes/klog@v2.50.0...v2.50.1 ### [`v2.50.0`](https://github.com/kubernetes/klog/releases/tag/v2.50.0): Prepare klog release for Kubernetes v1.24 (Take 3) [Compare Source](https://github.com/kubernetes/klog/compare/v2.40.1...v2.50.0) #### What's Changed - Panic on empty info with custom logr by [@​jklaw90](https://github.com/jklaw90) in [https://github.com/kubernetes/klog/pull/283](https://github.com/kubernetes/klog/pull/283) - Add missing Depth logging functions. by [@​s3rj1k](https://github.com/s3rj1k) in [https://github.com/kubernetes/klog/pull/280](https://github.com/kubernetes/klog/pull/280) - fix typo in klog.go by [@​cocaccola](https://github.com/cocaccola) in [https://github.com/kubernetes/klog/pull/270](https://github.com/kubernetes/klog/pull/270) - Update README.md by [@​noaabarki](https://github.com/noaabarki) in [https://github.com/kubernetes/klog/pull/281](https://github.com/kubernetes/klog/pull/281) - log filter: ignored by V, used during log call by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/290](https://github.com/kubernetes/klog/pull/290) - SetLogger/ClearLogger/SetLogFilter cleanup by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/289](https://github.com/kubernetes/klog/pull/289) - fixes for PR [#​280](https://github.com/kubernetes/klog/issues/280), refactoring, textlogger, unit test by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/287](https://github.com/kubernetes/klog/pull/287) - klogr verbosity by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/295](https://github.com/kubernetes/klog/pull/295) - test: fix Go version matrix by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/298](https://github.com/kubernetes/klog/pull/298) - handle panics in MarshalLog, Error, String by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/299](https://github.com/kubernetes/klog/pull/299) - Fix goroutine leak: make flushDaemon stoppable by [@​katexochen](https://github.com/katexochen) in [https://github.com/kubernetes/klog/pull/293](https://github.com/kubernetes/klog/pull/293) - structured logging: replacing Fatal/Exit/etc. without loss of flushing by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/303](https://github.com/kubernetes/klog/pull/303) - contextual logging by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/296](https://github.com/kubernetes/klog/pull/296) - remove side effects of tests by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/305](https://github.com/kubernetes/klog/pull/305) - tests: stop testing with Go 1.14 by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/304](https://github.com/kubernetes/klog/pull/304) #### New Contributors - [@​jklaw90](https://github.com/jklaw90) made their first contribution in [https://github.com/kubernetes/klog/pull/283](https://github.com/kubernetes/klog/pull/283) - [@​s3rj1k](https://github.com/s3rj1k) made their first contribution in [https://github.com/kubernetes/klog/pull/280](https://github.com/kubernetes/klog/pull/280) - [@​cocaccola](https://github.com/cocaccola) made their first contribution in [https://github.com/kubernetes/klog/pull/270](https://github.com/kubernetes/klog/pull/270) - [@​noaabarki](https://github.com/noaabarki) made their first contribution in [https://github.com/kubernetes/klog/pull/281](https://github.com/kubernetes/klog/pull/281) - [@​katexochen](https://github.com/katexochen) made their first contribution in [https://github.com/kubernetes/klog/pull/293](https://github.com/kubernetes/klog/pull/293) **Full Changelog**: kubernetes/klog@v2.40.1...v2.50.0 ### [`v2.40.1`](https://github.com/kubernetes/klog/releases/tag/v2.40.1): Prepare klog release for Kubernetes v1.24 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.40.0...v2.40.1) #### What's Changed - Using OS targeted go files to separate out the username logic. by [@​phillipsj](https://github.com/phillipsj) in [https://github.com/kubernetes/klog/pull/271](https://github.com/kubernetes/klog/pull/271) - Recover from nil pointers when logging by [@​dims](https://github.com/dims) in [https://github.com/kubernetes/klog/pull/279](https://github.com/kubernetes/klog/pull/279) #### New Contributors - [@​phillipsj](https://github.com/phillipsj) made their first contribution in [https://github.com/kubernetes/klog/pull/271](https://github.com/kubernetes/klog/pull/271) **Full Changelog**: kubernetes/klog@v2.40.0...v2.40.1 ### [`v2.40.0`](https://github.com/kubernetes/klog/releases/tag/v2.40.0): Prepare klog release for Kubernetes v1.24 [Compare Source](https://github.com/kubernetes/klog/compare/v2.30.0...v2.40.0) #### What's Changed - structured logging: support values with line breaks by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/273](https://github.com/kubernetes/klog/pull/273) - Fix klog lock release on panic error by [@​astraw99](https://github.com/astraw99) in [https://github.com/kubernetes/klog/pull/272](https://github.com/kubernetes/klog/pull/272) - add format test for KObjs by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/276](https://github.com/kubernetes/klog/pull/276) - add Verbose.InfoSDepth by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/277](https://github.com/kubernetes/klog/pull/277) #### Known Issues - [https://github.com/kubernetes/klog/issues/278](https://github.com/kubernetes/klog/issues/278) #### New Contributors - [@​astraw99](https://github.com/astraw99) made their first contribution in [https://github.com/kubernetes/klog/pull/272](https://github.com/kubernetes/klog/pull/272) **Full Changelog**: kubernetes/klog@v2.30.0...v2.40.0 ### [`v2.30.0`](https://github.com/kubernetes/klog/releases/tag/v2.30.0): Prepare klog release for Kubernetes v1.23 (take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.20.0...v2.30.0) #### What's Changed - Fix logcheck exit function by [@​luyou86](https://github.com/luyou86) in [https://github.com/kubernetes/klog/pull/265](https://github.com/kubernetes/klog/pull/265) - custom marshaler for ObjectRef by [@​pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/266](https://github.com/kubernetes/klog/pull/266) #### New Contributors - [@​luyou86](https://github.com/luyou86) made their first contribution in [https://github.com/kubernetes/klog/pull/265](https://github.com/kubernetes/klog/pull/265) **Full Changelog**: kubernetes/klog@v2.20.0...v2.30.0 ### [`v2.20.0`](https://github.com/kubernetes/klog/releases/tag/v2.20.0): Prepare klog release for Kubernetes v1.23 [Compare Source](https://github.com/kubernetes/klog/compare/v2.10.0...v2.20.0) Changes are here : kubernetes/klog@v2.10.0...v2.20.0 since we moved to logr v1.0.0, there are incompatible changes: - klogger.Enabled: changed from func() bool to func(int) bool - klogger.Info: changed from func(string, ...interface{}) to func(int, string, ...interface{}) - klogger.V: removed - klogger.WithCallDepth: changed from func(int) github.com/go-logr/logr.Logger to func(int) github.com/go-logr/logr.LogSink - klogger.WithName: changed from func(string) github.com/go-logr/logr.Logger to func(string) github.com/go-logr/logr.LogSink - klogger.WithValues: changed from func(...interface{}) github.com/go-logr/logr.Logger to func(...interface{}) github.com/go-logr/logr.LogSink [`83653a6`](https://github.com/kubernetes/klog/commit/83653a6deebf) Update to newest versions of golang 1.17.x [`d648c2e`](https://github.com/kubernetes/klog/commit/d648c2e42d30) fix file-based filtering symbolization [`8ee3d65`](https://github.com/kubernetes/klog/commit/8ee3d652c96b) export ClearLogger [`4171f3c`](https://github.com/kubernetes/klog/commit/4171f3c1be1b) Switching to logr tag v1.0.0 [`9ab3c2b`](https://github.com/kubernetes/klog/commit/9ab3c2b56cb2) add serathius as approvers of klog ### [`v2.10.0`](https://github.com/kubernetes/klog/releases/tag/v2.10.0): One more change to support 1.22 release [Compare Source](https://github.com/kubernetes/klog/compare/v2.9.0...v2.10.0) Changes are here : kubernetes/klog@v2.9.0...v2.10.0 new function added: func KObjs(arg interface{}) []ObjectRef ### [`v2.9.0`](https://github.com/kubernetes/klog/releases/tag/v2.9.0): Prepare release for Kubernetes v1.22 [Compare Source](https://github.com/kubernetes/klog/compare/v2.8.0...v2.9.0) Changes are here : kubernetes/klog@v2.8.0...v2.9.0 [`6a9ef3f`](https://github.com/kubernetes/klog/commit/6a9ef3fa9a15) fix typo [`59f7cb5`](https://github.com/kubernetes/klog/commit/59f7cb505f58) fix byte array display in InfoS and ErrorS [`cf22f1e`](https://github.com/kubernetes/klog/commit/cf22f1e79721) Call logr with call depth [`e95c7e3`](https://github.com/kubernetes/klog/commit/e95c7e303755) make SetLogger thread-safe [`2728fe1`](https://github.com/kubernetes/klog/commit/2728fe192acc) check usage of format specifier in structured log func [`a18bc97`](https://github.com/kubernetes/klog/commit/a18bc976a212) Fix by pr suggestions [`4e4135c`](https://github.com/kubernetes/klog/commit/4e4135c3dd8a) Add check for InfoS & ErrorS parameters ### [`v2.8.0`](https://github.com/kubernetes/klog/releases/tag/v2.8.0): Bug fixes for structured logging for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.7.0...v2.8.0) ### [`v2.7.0`](https://github.com/kubernetes/klog/releases/tag/v2.7.0): Miscellaneous fixes for structured logging for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.6.0...v2.7.0) Changes are here : kubernetes/klog@v2.6.0...v2.7.0 ### [`v2.6.0`](https://github.com/kubernetes/klog/releases/tag/v2.6.0): Adding a linter for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.5.0...v2.6.0) Changes are here : kubernetes/klog@v2.5.0...v2.6.0 please see https://github.com/kubernetes/klog/tree/master/hack/tools/logcheck ### [`v2.5.0`](https://github.com/kubernetes/klog/releases/tag/v2.5.0): Prepare release for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.4.0...v2.5.0) Changes are here : kubernetes/klog@v2.4.0...v2.5.0 klog.go has new API: +func ErrorSDepth(depth int, err error, msg string, keysAndValues ...interface{}) { +func InfoSDepth(depth int, msg string, keysAndValues ...interface{}) { klogr/klogr.go has new API: func (l klogger) WithCallDepth(depth int) logr.Logger { func NewWithOptions(options ...Option) logr.Logger { func WithFormat(format Format) Option { ### [`v2.4.0`](https://github.com/kubernetes/klog/releases/tag/v2.4.0): Prepare release for Kubernetes v1.20 [Compare Source](https://github.com/kubernetes/klog/compare/v2.3.0...v2.4.0) Changes are here : kubernetes/klog@v2.3.0...v2.4.0 ### [`v2.3.0`](https://github.com/kubernetes/klog/releases/tag/v2.3.0): Fix Typo-ed Method Error -> ErrorS [Compare Source](https://github.com/kubernetes/klog/compare/v2.2.0...v2.3.0) Changes are here : kubernetes/klog@v2.2.0...v2.3.0 ### [`v2.2.0`](https://github.com/kubernetes/klog/releases/tag/v2.2.0): Dependency update and bugfix for InfoS [Compare Source](https://github.com/kubernetes/klog/compare/2.1.0...v2.2.0) - [`2e691eb`](https://github.com/kubernetes/klog/commit/2e691eb3eeb3) Fix missing fields in verbose InfoS - [`966c986`](https://github.com/kubernetes/klog/commit/966c98681ca0) feat use go-logr v0.2.0 Changes are here : kubernetes/klog@v2.1.0...v2.2.0 ### [`v2.1.0`](https://github.com/kubernetes/klog/releases/tag/v2.1.0): Better support for Structured Logging [Compare Source](https://github.com/kubernetes/klog/compare/v2.0.0...2.1.0) We are now enforcing API compatibility, added Windows based tests, and have tweaked the structured logging methods after some real world experience updating kubernetes main repo. - [`bbd9ca1`](https://github.com/kubernetes/klog/commit/bbd9ca1) Add tests for error in InfoS - [`1ccc0e1`](https://github.com/kubernetes/klog/commit/1ccc0e1) fix imported bug time encode format form kvlistFormat - [`dd4d1a6`](https://github.com/kubernetes/klog/commit/dd4d1a6) fix typo in README.md - [`49123d4`](https://github.com/kubernetes/klog/commit/49123d4) ErrorS(nil, ...) should call loggr.Error(nil, ...) - [`5b199cd`](https://github.com/kubernetes/klog/commit/5b199cd) Fix documentation for V(level) - [`d1eb30f`](https://github.com/kubernetes/klog/commit/d1eb30f) Add apidiff script to check go signature changes - [`dc505bf`](https://github.com/kubernetes/klog/commit/dc505bf) Switch slack channel to #klog - [`a47ebb9`](https://github.com/kubernetes/klog/commit/a47ebb9) Add example for co-existence of klog v1 and v2 - [`134f148`](https://github.com/kubernetes/klog/commit/134f148) logName(): lazily lookup userName instead of on init() - [`db06a1b`](https://github.com/kubernetes/klog/commit/db06a1b) fix serialization of special html chars - [`5727d2a`](https://github.com/kubernetes/klog/commit/5727d2a) Fix Windows integration tests - [`edbc1d3`](https://github.com/kubernetes/klog/commit/edbc1d3) test(\*): TestRollover failed randomly on Windows - [`6f99060`](https://github.com/kubernetes/klog/commit/6f99060) Add LogToStderr, a programatic way to log exclusively to stderr or not ### [`v2.0.0`](https://github.com/kubernetes/klog/releases/tag/v2.0.0): Release to support Kubernetes v1.19 [Compare Source](https://github.com/kubernetes/klog/compare/v1.0.0...v2.0.0) Beware of type change: `Verbose` New Methods: - `SetLogger` (override logger to set a custom implementation) - `InfoS` (structured logging) - `ErrorS` (structured logging) Changes are here : kubernetes/klog@v2.0.0-rc.1...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
cparkins
referenced
this pull request
in AmadeusITGroup/opentelemetry-collector-contrib
Jan 10, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [k8s.io/klog](https://github.com/kubernetes/klog) | require | major | `v1.0.0` -> `v2.110.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes/klog (k8s.io/klog)</summary> ### [`v2.110.1`](https://github.com/kubernetes/klog/releases/tag/v2.110.1): Prepare klog release for Kubernetes v1.29 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.100.1...v2.110.1) #### What's Changed - fix: SetLogger via klog.SetLogger will output an unexpected newline by [@&open-telemetry#8203;aimuz](https://github.com/aimuz) in [https://github.com/kubernetes/klog/pull/378](https://github.com/kubernetes/klog/pull/378) - resolve comments warning by [@&open-telemetry#8203;lowang-bh](https://github.com/lowang-bh) in [https://github.com/kubernetes/klog/pull/379](https://github.com/kubernetes/klog/pull/379) - stderrthreshold: fix flag comment by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/376](https://github.com/kubernetes/klog/pull/376) - enable "go vet" checks for parameters by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/390](https://github.com/kubernetes/klog/pull/390) - promote experimental code to stable by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/392](https://github.com/kubernetes/klog/pull/392) - golangci-lint action by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/380](https://github.com/kubernetes/klog/pull/380) - output: handle WithName like zapr does by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/391](https://github.com/kubernetes/klog/pull/391) - slog support + logr 1.3.0 update by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/384](https://github.com/kubernetes/klog/pull/384) #### New Contributors - [@&open-telemetry#8203;aimuz](https://github.com/aimuz) made their first contribution in [https://github.com/kubernetes/klog/pull/378](https://github.com/kubernetes/klog/pull/378) - [@&open-telemetry#8203;lowang-bh](https://github.com/lowang-bh) made their first contribution in [https://github.com/kubernetes/klog/pull/379](https://github.com/kubernetes/klog/pull/379) **Full Changelog**: kubernetes/klog@v2.100.1...v2.110.1 ### [`v2.100.1`](https://github.com/kubernetes/klog/releases/tag/v2.100.1): Prepare klog release for Kubernetes v1.28 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.90.1...v2.100.1) #### What's Changed - expose logBridge via NewStandardLog() by [@&open-telemetry#8203;mikedanese](https://github.com/mikedanese) in [https://github.com/kubernetes/klog/pull/369](https://github.com/kubernetes/klog/pull/369) - add Format wrapper by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/374](https://github.com/kubernetes/klog/pull/374) - JSON as fallback encoding by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/375](https://github.com/kubernetes/klog/pull/375) #### New Contributors - [@&open-telemetry#8203;mikedanese](https://github.com/mikedanese) made their first contribution in [https://github.com/kubernetes/klog/pull/369](https://github.com/kubernetes/klog/pull/369) **Full Changelog**: kubernetes/klog@v2.90.1...v2.100.1 ### [`v2.90.1`](https://github.com/kubernetes/klog/releases/tag/v2.90.1): Prepare klog release for Kubernetes v1.27 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.90.0...v2.90.1) #### What's Changed - buffer: restore dropping of too large buffers by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/366](https://github.com/kubernetes/klog/pull/366) - ktesting improvements by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/365](https://github.com/kubernetes/klog/pull/365) - ktesting + textlogger config api by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/368](https://github.com/kubernetes/klog/pull/368) - textlogger write through by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/363](https://github.com/kubernetes/klog/pull/363) **Full Changelog**: kubernetes/klog@v2.90.0...v2.90.1 ### [`v2.90.0`](https://github.com/kubernetes/klog/releases/tag/v2.90.0): Prepare klog release for Kubernetes v1.27 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.80.1...v2.90.0) #### What's Changed - klog: benchmark the overhead when logging is off by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/355](https://github.com/kubernetes/klog/pull/355) - improve textlogger by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/362](https://github.com/kubernetes/klog/pull/362) **Full Changelog**: kubernetes/klog@v2.80.1...v2.90.0 ##### There are some API differences from previous version k8s.io/klog/v2/klogr contains incompatible changes: - klogger.Enabled: removed - klogger.Error: removed - klogger.Info: removed k8s.io/klog/v2/test contains incompatible changes: - InitKlog: changed from func() to func(testing.TB) *flag.FlagSet ### [`v2.80.1`](https://github.com/kubernetes/klog/releases/tag/v2.80.1): Prepare klog release for Kubernetes v1.26 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.80.0...v2.80.1) #### What's Changed - InitFlags concurrency fix by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/349](https://github.com/kubernetes/klog/pull/349) **Full Changelog**: kubernetes/klog@v2.80.0...v2.80.1 ### [`v2.80.0`](https://github.com/kubernetes/klog/releases/tag/v2.80.0): Prepare klog release for Kubernetes v1.26 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.70.1...v2.80.0) #### What's Changed - OWNERS: add harshanarayana by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/342](https://github.com/kubernetes/klog/pull/342) - kvlistformat: fix the issue with display marshalled value for non string type by [@&open-telemetry#8203;harshanarayana](https://github.com/harshanarayana) in [https://github.com/kubernetes/klog/pull/344](https://github.com/kubernetes/klog/pull/344) - Bump version of golang to 1.19 and drop older versions by [@&open-telemetry#8203;dims](https://github.com/dims) in [https://github.com/kubernetes/klog/pull/345](https://github.com/kubernetes/klog/pull/345) **Full Changelog**: kubernetes/klog@v2.70.1...v2.80.0 ### [`v2.70.1`](https://github.com/kubernetes/klog/releases/tag/v2.70.1): Prepare klog release for Kubernetes v1.25 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.70.0...v2.70.1) #### What's Changed - ktesting: handle test completion by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/337](https://github.com/kubernetes/klog/pull/337) - contextual logging: enable by default again by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/341](https://github.com/kubernetes/klog/pull/341) **Full Changelog**: kubernetes/klog@v2.70.0...v2.70.1 ### [`v2.70.0`](https://github.com/kubernetes/klog/releases/tag/v2.70.0): Prepare klog release for Kubernetes v1.25 (Take 1) [Compare Source](https://github.com/kubernetes/klog/compare/v2.60.1...v2.70.0) #### What's Changed - logcheck: contextual logging + enhanced checks by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/297](https://github.com/kubernetes/klog/pull/297) - hack/tools: drop dependency on golangci-lint by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/313](https://github.com/kubernetes/klog/pull/313) - StopFlushDaemon: document flushing on shutdown by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/314](https://github.com/kubernetes/klog/pull/314) - logcheck: fix detection of invalid \* regexp in filter by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/315](https://github.com/kubernetes/klog/pull/315) - README.md: clarify -logtostderr by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/319](https://github.com/kubernetes/klog/pull/319) - Trim duplicates by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/324](https://github.com/kubernetes/klog/pull/324) - replace KObjs with KObjSlice by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/322](https://github.com/kubernetes/klog/pull/322) - support logr.Marshaler by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/325](https://github.com/kubernetes/klog/pull/325) - internal: remove unused TrimDuplicates by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/326](https://github.com/kubernetes/klog/pull/326) - save and restore state by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/320](https://github.com/kubernetes/klog/pull/320) - GitHub: use apidiff with more recent Go by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/329](https://github.com/kubernetes/klog/pull/329) - remove hack/tools by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/330](https://github.com/kubernetes/klog/pull/330) - GIT-331: fix shadowing key from the kv pair by [@&open-telemetry#8203;harshanarayana](https://github.com/harshanarayana) in [https://github.com/kubernetes/klog/pull/332](https://github.com/kubernetes/klog/pull/332) - klog.Fatal backtrace revert by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/328](https://github.com/kubernetes/klog/pull/328) - ktesting: capture log data in memory by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/327](https://github.com/kubernetes/klog/pull/327) - GIT-275: add tests for int and struct keys by [@&open-telemetry#8203;harshanarayana](https://github.com/harshanarayana) in [https://github.com/kubernetes/klog/pull/333](https://github.com/kubernetes/klog/pull/333) #### New Contributors - [@&open-telemetry#8203;harshanarayana](https://github.com/harshanarayana) made their first contribution in [https://github.com/kubernetes/klog/pull/332](https://github.com/kubernetes/klog/pull/332) **Full Changelog**: kubernetes/klog@v2.60.1...v2.70.0 ### [`v2.60.1`](https://github.com/kubernetes/klog/releases/tag/v2.60.1): Prepare klog release for Kubernetes v1.24 (Take 6) [Compare Source](https://github.com/kubernetes/klog/compare/v2.60.0...v2.60.1) #### What's Changed - Cleanup OWNERS file by [@&open-telemetry#8203;serathius](https://github.com/serathius) in [https://github.com/kubernetes/klog/pull/309](https://github.com/kubernetes/klog/pull/309) - dependencies: avoid k8s.io/utils, fork clock code instead by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/310](https://github.com/kubernetes/klog/pull/310) - promote contextual logging APIs to stable by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/311](https://github.com/kubernetes/klog/pull/311) **Full Changelog**: kubernetes/klog@v2.60.0...v2.60.1 ### [`v2.60.0`](https://github.com/kubernetes/klog/releases/tag/v2.60.0): Prepare klog release for Kubernetes v1.24 (Take 5) [Compare Source](https://github.com/kubernetes/klog/compare/v2.50.2...v2.60.0) #### What's Changed - SetContextualLogger: remove unintentionally merged API call by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/308](https://github.com/kubernetes/klog/pull/308) **Full Changelog**: kubernetes/klog@v2.50.2...v2.60.0 ### [`v2.50.2`](https://github.com/kubernetes/klog/compare/v2.50.1...v2.50.2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.50.1...v2.50.2) ### [`v2.50.1`](https://github.com/kubernetes/klog/releases/tag/v2.50.1): Prepare klog release for Kubernetes v1.24 (Take 4) [Compare Source](https://github.com/kubernetes/klog/compare/v2.50.0...v2.50.1) #### What's Changed - SetLoggerWithOptions: support flushing by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/306](https://github.com/kubernetes/klog/pull/306) **Full Changelog**: kubernetes/klog@v2.50.0...v2.50.1 ### [`v2.50.0`](https://github.com/kubernetes/klog/releases/tag/v2.50.0): Prepare klog release for Kubernetes v1.24 (Take 3) [Compare Source](https://github.com/kubernetes/klog/compare/v2.40.1...v2.50.0) #### What's Changed - Panic on empty info with custom logr by [@&open-telemetry#8203;jklaw90](https://github.com/jklaw90) in [https://github.com/kubernetes/klog/pull/283](https://github.com/kubernetes/klog/pull/283) - Add missing Depth logging functions. by [@&open-telemetry#8203;s3rj1k](https://github.com/s3rj1k) in [https://github.com/kubernetes/klog/pull/280](https://github.com/kubernetes/klog/pull/280) - fix typo in klog.go by [@&open-telemetry#8203;cocaccola](https://github.com/cocaccola) in [https://github.com/kubernetes/klog/pull/270](https://github.com/kubernetes/klog/pull/270) - Update README.md by [@&open-telemetry#8203;noaabarki](https://github.com/noaabarki) in [https://github.com/kubernetes/klog/pull/281](https://github.com/kubernetes/klog/pull/281) - log filter: ignored by V, used during log call by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/290](https://github.com/kubernetes/klog/pull/290) - SetLogger/ClearLogger/SetLogFilter cleanup by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/289](https://github.com/kubernetes/klog/pull/289) - fixes for PR [#&open-telemetry#8203;280](https://github.com/kubernetes/klog/issues/280), refactoring, textlogger, unit test by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/287](https://github.com/kubernetes/klog/pull/287) - klogr verbosity by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/295](https://github.com/kubernetes/klog/pull/295) - test: fix Go version matrix by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/298](https://github.com/kubernetes/klog/pull/298) - handle panics in MarshalLog, Error, String by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/299](https://github.com/kubernetes/klog/pull/299) - Fix goroutine leak: make flushDaemon stoppable by [@&open-telemetry#8203;katexochen](https://github.com/katexochen) in [https://github.com/kubernetes/klog/pull/293](https://github.com/kubernetes/klog/pull/293) - structured logging: replacing Fatal/Exit/etc. without loss of flushing by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/303](https://github.com/kubernetes/klog/pull/303) - contextual logging by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/296](https://github.com/kubernetes/klog/pull/296) - remove side effects of tests by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/305](https://github.com/kubernetes/klog/pull/305) - tests: stop testing with Go 1.14 by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/304](https://github.com/kubernetes/klog/pull/304) #### New Contributors - [@&open-telemetry#8203;jklaw90](https://github.com/jklaw90) made their first contribution in [https://github.com/kubernetes/klog/pull/283](https://github.com/kubernetes/klog/pull/283) - [@&open-telemetry#8203;s3rj1k](https://github.com/s3rj1k) made their first contribution in [https://github.com/kubernetes/klog/pull/280](https://github.com/kubernetes/klog/pull/280) - [@&open-telemetry#8203;cocaccola](https://github.com/cocaccola) made their first contribution in [https://github.com/kubernetes/klog/pull/270](https://github.com/kubernetes/klog/pull/270) - [@&open-telemetry#8203;noaabarki](https://github.com/noaabarki) made their first contribution in [https://github.com/kubernetes/klog/pull/281](https://github.com/kubernetes/klog/pull/281) - [@&open-telemetry#8203;katexochen](https://github.com/katexochen) made their first contribution in [https://github.com/kubernetes/klog/pull/293](https://github.com/kubernetes/klog/pull/293) **Full Changelog**: kubernetes/klog@v2.40.1...v2.50.0 ### [`v2.40.1`](https://github.com/kubernetes/klog/releases/tag/v2.40.1): Prepare klog release for Kubernetes v1.24 (Take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.40.0...v2.40.1) #### What's Changed - Using OS targeted go files to separate out the username logic. by [@&open-telemetry#8203;phillipsj](https://github.com/phillipsj) in [https://github.com/kubernetes/klog/pull/271](https://github.com/kubernetes/klog/pull/271) - Recover from nil pointers when logging by [@&open-telemetry#8203;dims](https://github.com/dims) in [https://github.com/kubernetes/klog/pull/279](https://github.com/kubernetes/klog/pull/279) #### New Contributors - [@&open-telemetry#8203;phillipsj](https://github.com/phillipsj) made their first contribution in [https://github.com/kubernetes/klog/pull/271](https://github.com/kubernetes/klog/pull/271) **Full Changelog**: kubernetes/klog@v2.40.0...v2.40.1 ### [`v2.40.0`](https://github.com/kubernetes/klog/releases/tag/v2.40.0): Prepare klog release for Kubernetes v1.24 [Compare Source](https://github.com/kubernetes/klog/compare/v2.30.0...v2.40.0) #### What's Changed - structured logging: support values with line breaks by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/273](https://github.com/kubernetes/klog/pull/273) - Fix klog lock release on panic error by [@&open-telemetry#8203;astraw99](https://github.com/astraw99) in [https://github.com/kubernetes/klog/pull/272](https://github.com/kubernetes/klog/pull/272) - add format test for KObjs by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/276](https://github.com/kubernetes/klog/pull/276) - add Verbose.InfoSDepth by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/277](https://github.com/kubernetes/klog/pull/277) #### Known Issues - [https://github.com/kubernetes/klog/issues/278](https://github.com/kubernetes/klog/issues/278) #### New Contributors - [@&open-telemetry#8203;astraw99](https://github.com/astraw99) made their first contribution in [https://github.com/kubernetes/klog/pull/272](https://github.com/kubernetes/klog/pull/272) **Full Changelog**: kubernetes/klog@v2.30.0...v2.40.0 ### [`v2.30.0`](https://github.com/kubernetes/klog/releases/tag/v2.30.0): Prepare klog release for Kubernetes v1.23 (take 2) [Compare Source](https://github.com/kubernetes/klog/compare/v2.20.0...v2.30.0) #### What's Changed - Fix logcheck exit function by [@&open-telemetry#8203;luyou86](https://github.com/luyou86) in [https://github.com/kubernetes/klog/pull/265](https://github.com/kubernetes/klog/pull/265) - custom marshaler for ObjectRef by [@&open-telemetry#8203;pohly](https://github.com/pohly) in [https://github.com/kubernetes/klog/pull/266](https://github.com/kubernetes/klog/pull/266) #### New Contributors - [@&open-telemetry#8203;luyou86](https://github.com/luyou86) made their first contribution in [https://github.com/kubernetes/klog/pull/265](https://github.com/kubernetes/klog/pull/265) **Full Changelog**: kubernetes/klog@v2.20.0...v2.30.0 ### [`v2.20.0`](https://github.com/kubernetes/klog/releases/tag/v2.20.0): Prepare klog release for Kubernetes v1.23 [Compare Source](https://github.com/kubernetes/klog/compare/v2.10.0...v2.20.0) Changes are here : kubernetes/klog@v2.10.0...v2.20.0 since we moved to logr v1.0.0, there are incompatible changes: - klogger.Enabled: changed from func() bool to func(int) bool - klogger.Info: changed from func(string, ...interface{}) to func(int, string, ...interface{}) - klogger.V: removed - klogger.WithCallDepth: changed from func(int) github.com/go-logr/logr.Logger to func(int) github.com/go-logr/logr.LogSink - klogger.WithName: changed from func(string) github.com/go-logr/logr.Logger to func(string) github.com/go-logr/logr.LogSink - klogger.WithValues: changed from func(...interface{}) github.com/go-logr/logr.Logger to func(...interface{}) github.com/go-logr/logr.LogSink [`83653a6`](https://github.com/kubernetes/klog/commit/83653a6deebf) Update to newest versions of golang 1.17.x [`d648c2e`](https://github.com/kubernetes/klog/commit/d648c2e42d30) fix file-based filtering symbolization [`8ee3d65`](https://github.com/kubernetes/klog/commit/8ee3d652c96b) export ClearLogger [`4171f3c`](https://github.com/kubernetes/klog/commit/4171f3c1be1b) Switching to logr tag v1.0.0 [`9ab3c2b`](https://github.com/kubernetes/klog/commit/9ab3c2b56cb2) add serathius as approvers of klog ### [`v2.10.0`](https://github.com/kubernetes/klog/releases/tag/v2.10.0): One more change to support 1.22 release [Compare Source](https://github.com/kubernetes/klog/compare/v2.9.0...v2.10.0) Changes are here : kubernetes/klog@v2.9.0...v2.10.0 new function added: func KObjs(arg interface{}) []ObjectRef ### [`v2.9.0`](https://github.com/kubernetes/klog/releases/tag/v2.9.0): Prepare release for Kubernetes v1.22 [Compare Source](https://github.com/kubernetes/klog/compare/v2.8.0...v2.9.0) Changes are here : kubernetes/klog@v2.8.0...v2.9.0 [`6a9ef3f`](https://github.com/kubernetes/klog/commit/6a9ef3fa9a15) fix typo [`59f7cb5`](https://github.com/kubernetes/klog/commit/59f7cb505f58) fix byte array display in InfoS and ErrorS [`cf22f1e`](https://github.com/kubernetes/klog/commit/cf22f1e79721) Call logr with call depth [`e95c7e3`](https://github.com/kubernetes/klog/commit/e95c7e303755) make SetLogger thread-safe [`2728fe1`](https://github.com/kubernetes/klog/commit/2728fe192acc) check usage of format specifier in structured log func [`a18bc97`](https://github.com/kubernetes/klog/commit/a18bc976a212) Fix by pr suggestions [`4e4135c`](https://github.com/kubernetes/klog/commit/4e4135c3dd8a) Add check for InfoS & ErrorS parameters ### [`v2.8.0`](https://github.com/kubernetes/klog/releases/tag/v2.8.0): Bug fixes for structured logging for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.7.0...v2.8.0) ### [`v2.7.0`](https://github.com/kubernetes/klog/releases/tag/v2.7.0): Miscellaneous fixes for structured logging for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.6.0...v2.7.0) Changes are here : kubernetes/klog@v2.6.0...v2.7.0 ### [`v2.6.0`](https://github.com/kubernetes/klog/releases/tag/v2.6.0): Adding a linter for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.5.0...v2.6.0) Changes are here : kubernetes/klog@v2.5.0...v2.6.0 please see https://github.com/kubernetes/klog/tree/master/hack/tools/logcheck ### [`v2.5.0`](https://github.com/kubernetes/klog/releases/tag/v2.5.0): Prepare release for Kubernetes v1.21 [Compare Source](https://github.com/kubernetes/klog/compare/v2.4.0...v2.5.0) Changes are here : kubernetes/klog@v2.4.0...v2.5.0 klog.go has new API: +func ErrorSDepth(depth int, err error, msg string, keysAndValues ...interface{}) { +func InfoSDepth(depth int, msg string, keysAndValues ...interface{}) { klogr/klogr.go has new API: func (l klogger) WithCallDepth(depth int) logr.Logger { func NewWithOptions(options ...Option) logr.Logger { func WithFormat(format Format) Option { ### [`v2.4.0`](https://github.com/kubernetes/klog/releases/tag/v2.4.0): Prepare release for Kubernetes v1.20 [Compare Source](https://github.com/kubernetes/klog/compare/v2.3.0...v2.4.0) Changes are here : kubernetes/klog@v2.3.0...v2.4.0 ### [`v2.3.0`](https://github.com/kubernetes/klog/releases/tag/v2.3.0): Fix Typo-ed Method Error -> ErrorS [Compare Source](https://github.com/kubernetes/klog/compare/v2.2.0...v2.3.0) Changes are here : kubernetes/klog@v2.2.0...v2.3.0 ### [`v2.2.0`](https://github.com/kubernetes/klog/releases/tag/v2.2.0): Dependency update and bugfix for InfoS [Compare Source](https://github.com/kubernetes/klog/compare/2.1.0...v2.2.0) - [`2e691eb`](https://github.com/kubernetes/klog/commit/2e691eb3eeb3) Fix missing fields in verbose InfoS - [`966c986`](https://github.com/kubernetes/klog/commit/966c98681ca0) feat use go-logr v0.2.0 Changes are here : kubernetes/klog@v2.1.0...v2.2.0 ### [`v2.1.0`](https://github.com/kubernetes/klog/releases/tag/v2.1.0): Better support for Structured Logging [Compare Source](https://github.com/kubernetes/klog/compare/v2.0.0...2.1.0) We are now enforcing API compatibility, added Windows based tests, and have tweaked the structured logging methods after some real world experience updating kubernetes main repo. - [`bbd9ca1`](https://github.com/kubernetes/klog/commit/bbd9ca1) Add tests for error in InfoS - [`1ccc0e1`](https://github.com/kubernetes/klog/commit/1ccc0e1) fix imported bug time encode format form kvlistFormat - [`dd4d1a6`](https://github.com/kubernetes/klog/commit/dd4d1a6) fix typo in README.md - [`49123d4`](https://github.com/kubernetes/klog/commit/49123d4) ErrorS(nil, ...) should call loggr.Error(nil, ...) - [`5b199cd`](https://github.com/kubernetes/klog/commit/5b199cd) Fix documentation for V(level) - [`d1eb30f`](https://github.com/kubernetes/klog/commit/d1eb30f) Add apidiff script to check go signature changes - [`dc505bf`](https://github.com/kubernetes/klog/commit/dc505bf) Switch slack channel to #klog - [`a47ebb9`](https://github.com/kubernetes/klog/commit/a47ebb9) Add example for co-existence of klog v1 and v2 - [`134f148`](https://github.com/kubernetes/klog/commit/134f148) logName(): lazily lookup userName instead of on init() - [`db06a1b`](https://github.com/kubernetes/klog/commit/db06a1b) fix serialization of special html chars - [`5727d2a`](https://github.com/kubernetes/klog/commit/5727d2a) Fix Windows integration tests - [`edbc1d3`](https://github.com/kubernetes/klog/commit/edbc1d3) test(\*): TestRollover failed randomly on Windows - [`6f99060`](https://github.com/kubernetes/klog/commit/6f99060) Add LogToStderr, a programatic way to log exclusively to stderr or not ### [`v2.0.0`](https://github.com/kubernetes/klog/releases/tag/v2.0.0): Release to support Kubernetes v1.19 [Compare Source](https://github.com/kubernetes/klog/compare/v1.0.0...v2.0.0) Beware of type change: `Verbose` New Methods: - `SetLogger` (override logger to set a custom implementation) - `InfoS` (structured logging) - `ErrorS` (structured logging) Changes are here : kubernetes/klog@v2.0.0-rc.1...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I've been using ktesting in the context of k8s.io/kubernetes/test/integration/scheduler_perf and would like to suggest some enhancements:
Special notes for your reviewer:
Here's how this will be used in Kubernetes: kubernetes/kubernetes#115506
Release note: