Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use info in default stderrThreshold #42

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Feb 4, 2019

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:
This PR is a follow-up to #39, it sets the default threshold for stderr logging to INFO.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

The default stderrThreshold has been set to info instead of error, you can use `-stderrthreshold=ERROR` to revert to the old behavior.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2019
@dims
Copy link
Member

dims commented Feb 4, 2019

/approve

let's wait to see if anyone objects for a little bit

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019
Signed-off-by: Vince Prignano <vincepri@vmware.com>
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
seems like the right thing to do after the previous PR.

@vincepri
Copy link
Member Author

vincepri commented Feb 7, 2019

@dims Should we merge this? I'm eager to update some repos and cleanup init(s).

@dims
Copy link
Member

dims commented Feb 7, 2019

go for it @vincepri

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 71442cd into kubernetes:master Feb 7, 2019
mtaufen added a commit to mtaufen/klog that referenced this pull request Mar 4, 2019
…-stderr"

This reverts commit 71442cd, reversing
changes made to 5093042.
@mtaufen mtaufen mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants