Set default values only once #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @vincepri! |
mtaufen
added a commit
to mtaufen/kubernetes
that referenced
this pull request
May 22, 2019
Includes recent fixes, notably kubernetes/klog#66
k8s-publishing-bot
pushed a commit
to kubernetes/code-generator
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/code-generator
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/apimachinery
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/apimachinery
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/api
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/api
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/client-go
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/client-go
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/component-base
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/component-base
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/apiserver
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/apiserver
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/metrics
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/metrics
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/cli-runtime
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/cli-runtime
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/sample-cli-plugin
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/sample-cli-plugin
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kube-proxy
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kube-proxy
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kubelet
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kubelet
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kube-scheduler
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kube-scheduler
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kube-controller-manager
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/kube-controller-manager
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/cluster-bootstrap
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/cluster-bootstrap
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/cloud-provider
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/cloud-provider
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/csi-translation-lib
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/csi-translation-lib
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/legacy-cloud-providers
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/legacy-cloud-providers
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/node-api
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
k8s-publishing-bot
pushed a commit
to kubernetes/node-api
that referenced
this pull request
May 28, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
superlime
pushed a commit
to superlime/kubernetes
that referenced
this pull request
Jun 3, 2019
Includes recent fixes, notably kubernetes/klog#66
nikhita
pushed a commit
to nikhita/kubernetes
that referenced
this pull request
Jun 13, 2019
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc5
tamalsaha
pushed a commit
to kmodules/shared-informer
that referenced
this pull request
Aug 13, 2020
Includes recent fixes, notably kubernetes/klog#66 Kubernetes-commit: ee7bcc53a206f669b057e38a477b51b3477aab23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR fixes an issue where
InitFlagswould overwrite values with defaults if called more than once. Props to @liggitt for the sync.Once idea kubernetes/kubernetes#77562 (comment)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to
Special notes for your reviewer:
Test is very simple, I can add more extensive ones if needed.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: