Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use libcompose project.Context{} instead of docker.Context{}? #134

Closed
weitenghuang opened this issue Aug 31, 2016 · 3 comments
Closed
Assignees

Comments

@weitenghuang
Copy link

I may miss something, but I don't understand why we will need to use &docker.Context{} when we load compose file in loader pkg
Isn't project.Context{} sufficient? The difference are:

    ClientFactory client.Factory
    ConfigDir     string
    ConfigFile    *configfile.ConfigFile
    AuthLookup    auth.Lookup
@surajssd
Copy link
Member

surajssd commented Sep 2, 2016

I think we had discussion on similar lines at #67 (comment) and #67 (comment) please correct me if I got you all wrong?

@weitenghuang
Copy link
Author

I propose we use project.Context for the same reason you referred in #67 (comment). We don't need to use libcompose's docker pkg context, if kompose is not meant to build a docker client.
Both support EnvironmentLookup.
Furthermore, I will help to resolve libcompose #372, so we don't need to copy the code here as well.

@ngtuna
Copy link
Contributor

ngtuna commented Sep 4, 2016

+1 @weitenghuang. I made a PR for that. Once your PR solving docker/libcompose#372 get in, we can remove the copied code.

@ngtuna ngtuna self-assigned this Sep 5, 2016
ngtuna added a commit to ngtuna/kompose that referenced this issue Sep 5, 2016
cab105 pushed a commit to cab105/kompose that referenced this issue Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants