Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kompose should respect the dockerfile key in docker-compose.yml #486

Closed
stephanosbacon opened this issue Mar 10, 2017 · 1 comment
Closed

kompose should respect the dockerfile key in docker-compose.yml #486

stephanosbacon opened this issue Mar 10, 2017 · 1 comment
Labels
priority/P1

Comments

@stephanosbacon
Copy link

If one doesn't use the default Dockerfile, but specified it using dockerfile: in the yml, the generated build config does not have a dockerFilePath: under dockerStrategy. This is in version 0.3.0 (HEAD)
@surajnarwade
Copy link
Contributor

I would like to work on it :)

surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 20, 2017
@surajnarwade
Added dockerfile key support
0727418 
Fixes kubernetes#486
This commit will add `dockerfilepath` key under Dockerstratergy in Buildconfig.
dockerfilepath allow us to use dockerfiles which are named different than `Dockerfile`
@surajnarwade surajnarwade mentioned this issue Mar 20, 2017
Merged
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 21, 2017
@surajnarwade
Added dockerfile key support
bb1b52e 
Fixes kubernetes#486
This commit will add `dockerfilepath` key under Dockerstratergy in Buildconfig.
dockerfilepath allow us to use dockerfiles which are named different than `Dockerfile`
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 22, 2017
@surajnarwade
Added dockerfile key support
61d4692 
Fixes kubernetes#486
This commit will add `dockerfilepath` key under Dockerstratergy in buildconfig.
dockerfilepath allow us to use dockerfiles which are named different than `Dockerfile` which are placed in context directory.

for example, for a docker-compose file:

```
version: "2"
services:
    foo:
        build:
            context: "./build"
            dockerfile: "Dockerfile-alternate"
        command: "sleep 3600"
```
Resulting buildconfig will be:

```
apiVersion: v1
kind: BuildConfig
...
...
  strategy:
    dockerStrategy:
      dockerfilePath: Dockerfile-alternate
    type: Docker
...
...
```
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 22, 2017
@surajnarwade
Added dockerfile key support
ec897ef 
Fixes kubernetes#486
This commit will add `dockerfilepath` key under Dockerstratergy in buildconfig.
dockerfilepath allow us to use dockerfiles which are named different than `Dockerfile` which are placed in context directory.

for example, for a docker-compose file:

```
version: "2"
services:
    foo:
        build:
            context: "./build"
            dockerfile: "Dockerfile-alternate"
        command: "sleep 3600"
```
Resulting buildconfig will be:

```
apiVersion: v1
kind: BuildConfig
...
...
  strategy:
    dockerStrategy:
      dockerfilePath: Dockerfile-alternate
    type: Docker
...
...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kadel @stephanosbacon @surajnarwade