Add label 'kompose.controller.type' set service convert controller type

[xianlubird]

A standard wordpress compose like this

web:
  image: wordpress:4.5
  ports:
    - '80'
  environment:
    WORDPRESS_AUTH_KEY: changeme
    WORDPRESS_SECURE_AUTH_KEY: changeme
    WORDPRESS_LOGGED_IN_KEY: changeme
    WORDPRESS_NONCE_KEY: changeme
    WORDPRESS_AUTH_SALT: changeme
    WORDPRESS_SECURE_AUTH_SALT: changeme
    WORDPRESS_LOGGED_IN_SALT: changeme
    WORDPRESS_NONCE_SALT: changeme
    WORDPRESS_NONCE_AA: changeme
  restart: always
  links:
    - 'db:mysql'
db:
  image: mysql:5.7
  environment:
    MYSQL_ROOT_PASSWORD: password
  restart: always
  labels:
    project.logs: /var/log/mysql

For service db, we'd better convert it to StatefulSet. But if we run command kompose convert -f , all of them are converted to Deployment. We have to split them into two compose file.So we'd better support a label which can control what type you want to convert.

After that, a compose like this

web:
  image: wordpress:4.5
  ports:
    - '80'
  environment:
    WORDPRESS_AUTH_KEY: changeme
    WORDPRESS_SECURE_AUTH_KEY: changeme
    WORDPRESS_LOGGED_IN_KEY: changeme
    WORDPRESS_NONCE_KEY: changeme
    WORDPRESS_AUTH_SALT: changeme
    WORDPRESS_SECURE_AUTH_SALT: changeme
    WORDPRESS_LOGGED_IN_SALT: changeme
    WORDPRESS_NONCE_SALT: changeme
    WORDPRESS_NONCE_AA: changeme
  restart: always
  links:
    - 'db:mysql'
db:
  image: mysql:5.7
  environment:
    MYSQL_ROOT_PASSWORD: password
  restart: always
  labels:
    project.logs: /var/log/mysql
    kompose.controller.type: daemonset

So service web convert to Deployment, service db convert to StatefulSet, it's very useful.

What's your opinion, @cdrage @hangyan

[xianlubird]

@cdrage @hangyan If you have time, pls review this. Thanks.

[cdrage]

I fully support this. However, a few more things need to be added:

• Documentation for StatefulSet
• A new flag should be added (to --controller!)

This will close a bunch of issues. Specifically, the one regarding #698 !

[xianlubird]

@cdrage @hangyan

Thanks for your review.

• Already add document for label kompose.controller.type
• For a new flag , now we already have --controller flag and support three types, run kompose convert --help can see it

./kompose convert --help
Convert a Docker Compose file

Usage:
  kompose convert [file] [flags]

--controller string   Set the output controller ("deployment"|"daemonSet"|"replicationController")

This pr support that ,user can use kompose convert -f test.yml. If a service have label kompose.controller.type, it will be converted to the type which use specified, for other service in the same compose file, it will convert to default controller type or user specified type in --controller xxxxx.

[xianlubird]

@cdrage any update?

[cdrage]

Hey @xianlubird I'll find some time this week / early next week to do another review 👍 Maybe @hangyan could do one on this PR and #994 (comment) ?

[cdrage]

I don't think you're implementing statefulset at all? You're only adding the new label type. Bit confused what you're trying to accomplish here.

[cdrage]

aren't you missing statefulset?

[cdrage]

this is totally wrong... if you specify kompose.controller.type daemonset, this should be converted to daemonset... if you supply statefulset, this should be converted to statefulset..

[cdrage]

add statefulset

[xianlubird]

@cdrage Yes, I make a mistake for DaemonSet and StatefulSet. This pr , I just want to add a label for that different service in one yaml file can convert to different k8s type. For this purpose, I raise this pr.

So in your opinion, I should implement StatefulSet in this PR? Or just add a label for deployment and DaemonSet and implement StatefulSet in another PR ?

many thanks.

[cdrage]

Hey @xianlubird

For now, just implement the label, but please correct that daemonset will be converted to daemonset.

We should raise another PR in the future for adding statefulset (see issue: #698 )

[xianlubird]

@cdrage
Already change document to DaemonSet.
I will raise another PR to implement StatefulSet.
Thanks for your review.

[cdrage]

This LGTM. I'd like @kadel or @hangyan to review this too since it's fairly large.

[hangyan]

@xianlubird Please add OpenShift test files

[xianlubird]

@hangyan Already add OpenShift test case, thanks.

[xianlubird]

@kadel @hangyan Any update on this.

[hangyan]

/lgtm