-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label support to named volumes in docker compose v3 to Kubernetes #1083
Conversation
…nd apply to kubernetes supported volume size
…e same kubernetes deploy
…se.volume.selector) is used in named volume
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is there any way for you to add tests? If you run into any difficulty I don't mind helping out 👍 |
I added a test case for the new labels |
Tests pass: https://semaphoreci.com/cdrage/kompose-2 This LGTM! |
kompose.volume.selector
- Add selector.matchLabels to kubernetes PVC for volume bindingkompose.volume.size
- Change kubernetes supported volume size for docker named volumesFor example, the above named volume (database-vol) defined in docker compose file will convert to following Kubernetes config
Fix the PVC size in log message when deploy Kubernetes
Skip creation of PVC if it is already created in the same kubernetes deploy