-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kompose up for OpenShift #200
Conversation
Does it (g/docker/docker) conflict revision with one I upgraded at #174 ? |
39fe234
to
df10937
Compare
It was in conflict even before that :-( It his PR I'm using |
1bf46d5
to
2273436
Compare
🎉 , now it is ready for testing and review |
Do you have tests in there for conversion to DeploymentConfigs and ImageStreams ? does not look like Travis run any. Also if would be good to add a user-guide in /docs .... |
Yes, test for DeploymentConfigs are there (every conversion to OpenShift generates DeploymentConfig). Same for ImageStreams, every OpenShift conversion generates ImageStream, tests was updated in #160 |
I've added commit with updated user-guide. |
seems to be working for me - one of my imagestreams was not working right, but I think that might be another issue. |
ok - i'm having some trouble with image streams in the example I am trying to do. This is the file: https://github.com/dustymabe/kompose/blob/dusty-foo-bar/examples/mlbparks.yml When I create with openshift it doesn't work complaining about imagepullbackoff for the dustymabe/mlbparks image. Here is what I used to get into openshift:
When I convert to "pretend" that I am kube by passing --rc then the image pulls fine and the application comes up. Here is that command:
The openshift environment I am targeting is:
|
hmm :-( It complained only for dustymabe/mlbparks image? centos/mongodb-26-centos7 pulled successfully? |
Then I wouldn't worry about it. Most likely my setup.
yes. It only complained for one of the images. The onther one was fine. |
Can we get this rebased? :) |
kompose --provider openshift up
OpenShift version 1.4.0-alpha.0
ae7c583
to
661bce5
Compare
Ah, It conflicted with my other PR :-) Rebased. |
@dustymabe I think some of us don't have Openshift account for testing. But you guys made some tests already and user-guide was also added, it should be good to let it pass. We can always open issue later. |
Thanks @kadel for the reference 👍 On Tuesday, October 18, 2016, Tomas Kral notifications@github.com wrote:
Regards, |
@ngtuna also you can try out for free in openshift online: https://www.openshift.com/devpreview/ |
@dustymabe @kadel so this worked for me when I tried it today with the docker-compose file in examples well. |
kompose --provider openshift up
This has similar behavior as
kompose up
for k8s. It assumes that you already have.kube/config
setup (you are logged usingoc login
).It converts docker-compose.yaml to DeploymentConfigs, Services and ImageStreams, those objects are then deployed to OpenShift cluster.
This PR also updates bunch of vendored libs.
Mainly OpenShift 1.4.0-alpha.0 this is required to avoid collisions between Docker version that is required by OpenShift and version that Kompose requires for bundle support.
Upgrading OpenShift forced updates for a lots of other libs. Kubernetes is now in version v1.4.0-beta.3
#40
requires #199- mergedIssues:
Can't update vendored libs :-(godep save ./...godep: Package (github.com/docker/docker/pkg/term/winconsole) not found
Solved in 2273436 - upgrading OpenShift to 1.4.0-apha.0 this version is using docker version that is compatible version that we require for bundle support.
is still not working (fails while creating deployment) :-(All issues are solved, and it is ready for review