Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement storing to directory or file, add functional tests #337

Merged
merged 1 commit into from
Dec 21, 2016
Merged

implement storing to directory or file, add functional tests #337

merged 1 commit into from
Dec 21, 2016

Conversation

concaf
Copy link
Contributor

@concaf concaf commented Dec 14, 2016

Fix #209

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2016
@surajssd
Copy link
Member

surajssd commented Dec 14, 2016 •
edited
Loading

wow Travis has still not started build, its more than hour now!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 34.208% when pulling be1efb2 on containscafeine:output_file_dir into 65e19e3 on kubernetes-incubator:master.

@concaf concaf force-pushed the output_file_dir branch 2 times, most recently from 4809abc to f1e3a7f Compare December 15, 2016 15:10
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 36.009% when pulling f1e3a7f on containscafeine:output_file_dir into 78845d3 on kubernetes-incubator:master.

@cdrage
Copy link
Member

cdrage commented Dec 15, 2016

It looks like the commit message is empty? I only see a title in there.

@concaf
Copy link
Contributor Author

concaf commented Dec 15, 2016

@cdrage, whoops, fixed!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 36.009% when pulling dac70d8 on containscafeine:output_file_dir into 78845d3 on kubernetes-incubator:master.

@surajssd
Copy link
Member

LGTM!

@surajssd surajssd added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2016
@surajssd surajssd self-requested a review December 19, 2016 15:34
@cdrage
Copy link
Member

cdrage commented Dec 19, 2016

Code LGTM, however @containscafeine mind explaining a little bit on the usage (how to use?). Seeing if we need to update the docs for this change :)

@surajssd surajssd added rebase needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 19, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 38.939% when pulling a782a5e on containscafeine:output_file_dir into c485a87 on kubernetes-incubator:master.

@concaf
implement storing to dir/file, add tests
365fe81 
When kompose convert -o artifacts is run, then if artifacts is a directory,
kompose stores all the resulting files inside it, and if it's not a directory,
it stores the artifacts in a single file.

Fixes kubernetes#209
@concaf
Copy link
Contributor Author

concaf commented Dec 21, 2016

@surajssd @cdrage updated the usage for the flag -o. Should be good to go now?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 38.939% when pulling 365fe81 on containscafeine:output_file_dir into c485a87 on kubernetes-incubator:master.

@surajssd
Copy link
Member

@containscafeine thanks merging it!

@surajssd surajssd merged commit 5ddd48e into kubernetes:master Dec 21, 2016
@cflee cflee mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajssd surajssd surajssd approved these changes

@cdrage cdrage cdrage approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. rebase needed review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@concaf @surajssd @coveralls @cdrage @k8s-ci-robot