new take on "Kompose will keep trying its job #477" #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes kubernetes#270 all errors in undeploy method(both kubernetes and openshift) are appended in a slice of errors, and then it will be returned after successful deletion of all components.
k8s-ci-robot
added
the
cncf-cla: yes
cdrage
approved these changes
Apr 3, 2017
| } | ||
|
|
||
| client, namespace, err := k.GetKubernetesClient() | ||
| if err != nil { | ||
| return err | ||
| errorList = append(errorList, err) | ||
| return errorList |
surajnarwade
approved these changes
Apr 4, 2017
|
LGTM |
cdrage
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reopening of #477 there were some issues that we forgot to address.
Issue was that if it can't connect to cluster it panics.
Problem is that we continue after every error.
There should be return after some errors, and after every error in switch should be break so we don't
try to get reaper using client which creation field or calling
Stopon reaper that field to create.I've added new commit on top of original @surajnarwade's commit, so its easier to review.
Once we agreed that this is the way we wan't to do it we can squash it