Kompose should show an error when image is not given #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
@procrypt fix the tests that are failing, you might need to change the test to |
procrypt
force-pushed
the
error_build_kubernetes
branch
2 times, most recently
from
93b4b8f to
e47267a
Compare
we should give an error about it when we run kompose convert.
procrypt
force-pushed
the
error_build_kubernetes
branch
from
e47267a to
f21e8f9
Compare
|
Errr this shouldn't error.. If we pass in build but no image, the assumption is that the service name takes up the image name. See my PR at how I get around this at #521 It's by default in Docker Compose too :) You don't have to pass in |
|
@cdrage about using the auto-generated name it's okay when user is doing the builds, but here we are not doing builds with k8s as of now, so not doing magic is what I would expect. |
|
I'd suggest we close this until #521 is merged as this will add build support for Kubernetes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kompose passes a kubernetes deployment without image, we should give an error about it.
Fixes: #571
cc: @surajssd @cdrage