Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version column from conversion document #615

Merged
merged 1 commit into from
May 30, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented May 23, 2017

Removes the version column in order to expand the width of the
conversion document as well as indicate that the table expands on ALL
versions (1,2,3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2017
@surajnarwade
Copy link
Contributor

surajnarwade commented May 29, 2017

after expanding width, table looks good now

@surajssd
Copy link
Member

Table looks like this right now!
screenshot from 2017-05-29 15-18-45

@cdrage
Copy link
Member Author

cdrage commented May 29, 2017

@surajssd Ah shoot. I'll fix it.

Removes the version column in order to expand the width of the
conversion document as well as indicate that the table expands on ALL
versions (1,2,3)
@cdrage
Copy link
Member Author

cdrage commented May 29, 2017

@surajssd @surajnarwade Fixed. I've also added spacing for those reading directly from a non-formatted markdown file.

Feel free to check it out now.

@cdrage
Copy link
Member Author

cdrage commented May 29, 2017

@surajssd
Copy link
Member

cool this LGTM!

@surajssd surajssd merged commit 2a708bc into kubernetes:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants