Fix OpenShift tests for build and push #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
ashetty1
changed the title
|
@cdrage @surajnarwade review please |
cdrage
requested changes
Jun 29, 2017
script/test_in_openshift/lib.sh
Outdated
| @@ -202,6 +202,7 @@ function convert::kompose_up () { | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| foo: | ||
| build: "./build" | ||
| command: sleep 100 | ||
|
|
| FROM busybox:1.26.2 | ||
|
|
||
| RUN touch /test | ||
|
|
This patch fixes the broken buildconfig functional tests
cdrage
approved these changes
Jul 18, 2017
|
@surajssd Can you do a quick review / look-over and then merge? |
|
@ashetty1 , small change |
|
Thanks @ashetty1 ! Let's see if this new build passes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Work in Progress]
This patch fixes the broken buildconfig functional tests and also will add more tests for the new build and push feature.