Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes kompose.service.type label issue #674

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Fixes kompose.service.type label issue #674

merged 1 commit into from
Jun 28, 2017

Conversation

surajnarwade
Copy link
Contributor

Minor Fix, resolves #673

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2017
@surajnarwade
Copy link
Contributor Author

@cdrage @surajssd review needed

@cdrage
Copy link
Member

cdrage commented Jun 27, 2017

LGTM.

I actually encountered this issue before a demo yesterday. I think this is high-priority since our main examples use it (see http://kompose.io). 👎

Any way to add tests too so this does not happen again @surajnarwade ?

@cdrage cdrage mentioned this pull request Jun 27, 2017
Closed
@surajnarwade
Copy link
Contributor Author

@cdrage , tests are already there, i dont think we can add any more tests

@cdrage cdrage merged commit 2c0441d into kubernetes:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel approved these changes

@cdrage cdrage cdrage approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kompose.service.type issues
4 participants
@surajnarwade @cdrage @kadel @k8s-ci-robot