Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix healthcheck parser nil pointer error #936

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Fix healthcheck parser nil pointer error #936

merged 1 commit into from
Feb 20, 2018

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Feb 9, 2018 •
edited
Loading

fix #934

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2018
@cdrage
Copy link
Member

cdrage commented Feb 20, 2018

Thanks for writing those tests as well. Tests pass and code LGTM! Thank you!

@cdrage cdrage merged commit 170acd9 into kubernetes:master Feb 20, 2018
@hangyan hangyan deleted the fix-healthcheck-bug branch March 31, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: runtime error: invalid memory address or nil pointer dereference SIGSEGV related to Healthcheck
3 participants
@hangyan @cdrage @k8s-ci-robot