Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github.com/go-viper/mapstructure/v2 #16402

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Use github.com/go-viper/mapstructure/v2 #16402

merged 1 commit into from
Mar 12, 2024

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 11, 2024

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/provider/openstack Issues or PRs related to openstack provider labels Mar 11, 2024
@ameukam ameukam marked this pull request as ready for review March 12, 2024 12:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@ameukam
Use github.com/go-viper/mapstructure/v2
cf3d7af 
Update mapstructure with a maintained fork.

See:
  - mitchellh/mapstructure#349

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Mar 12, 2024

/test pull-kops-aws-distro-debian10

@ameukam
Copy link
Member Author

ameukam commented Mar 12, 2024

/test pull-kops-aws-distro-debian11
/test pull-kops-aws-distro-debian12
/test pull-kops-aws-distro-ubuntu2004
/test pull-kops-aws-distro-ubuntu2004arm64
/test pull-kops-aws-distro-ubuntu2204
/test pull-kops-aws-distro-ubuntu2204arm64
/test pull-kops-aws-distro-amazonlinux2
/test pull-kops-aws-distro-al2023
/test pull-kops-aws-distro-rhel8
/test pull-kops-aws-distro-rhel9
/test pull-kops-aws-distro-rocky8
/test pull-kops-aws-distro-flatcar

1 similar comment
@hakman
Copy link
Member

hakman commented Mar 12, 2024

/test pull-kops-aws-distro-debian11
/test pull-kops-aws-distro-debian12
/test pull-kops-aws-distro-ubuntu2004
/test pull-kops-aws-distro-ubuntu2004arm64
/test pull-kops-aws-distro-ubuntu2204
/test pull-kops-aws-distro-ubuntu2204arm64
/test pull-kops-aws-distro-amazonlinux2
/test pull-kops-aws-distro-al2023
/test pull-kops-aws-distro-rhel8
/test pull-kops-aws-distro-rhel9
/test pull-kops-aws-distro-rocky8
/test pull-kops-aws-distro-flatcar

@ameukam
Copy link
Member Author

ameukam commented Mar 12, 2024

/retest

@hakman
Copy link
Member

hakman commented Mar 12, 2024

Great success @ameukam! 😄
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@ameukam
Copy link
Member Author

ameukam commented Mar 12, 2024

@hakman I think we need figure out remaining jobs (mostly presubmits/periodics for upgrades tests) post kubecon.

@k8s-ci-robot k8s-ci-robot merged commit b7c2464 into kubernetes:master Mar 12, 2024
35 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Mar 12, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

@hakman hakman Awaiting requested review from hakman

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @hakman