Support publishing CI artifacts to S3 #16659
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rifelpet
force-pushed
the
s3-stage-location
branch
from
8e2ecb8
to
85e8356
Compare
| @@ -34,6 +36,7 @@ import ( | |||
| const ( | |||
| defaultJobName = "pull-kops-e2e-kubernetes-aws" | |||
| defaultGCSPath = "gs://k8s-staging-kops/pulls/%v/pull-%v" | |||
| defaultS3Path = "s3://k8s-infra-kops-ci-results/pulls/%v/pull-%v" | |||
There was a problem hiding this comment.
Created by kubernetes/k8s.io#6950
rifelpet
changed the title
rifelpet
force-pushed
the
s3-stage-location
branch
from
85e8356
to
35c1d03
Compare
|
@rifelpet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
We want kubetest2-kops to dynamically create a temporary s3 bucket when the presubmit is running, similar to this code I made the IAM changes, but it allows presubmits to write to our CI bucket which isn't ideal(existing behaviour we should change). |
|
Yes I see the migrated job on your PR passed, using k8s-staging-kops: I believe this means we could migrate all presubmit jobs to use this, but you're right giving presubmit jobs write permissions to the same bucket used for post-merge artifacts like version markers is not great. We have the |
|
For now, let's retain the existing behaviour as AWS presubmits have been writing to the k8s-staging-kops bucket and let's try to switch to dynamic buckets on AWS. As for gs://k8s-infra-kops-ci-results, I don't want to use this bucket and we should delete it. |
| @@ -271,6 +274,15 @@ gcs-publish-ci: gsutil version-dist-ci | |||
| echo "${GCS_URL}/${VERSION}" > ${UPLOAD}/${LATEST_FILE} | |||
| gsutil -h "Cache-Control:private, max-age=0, no-transform" cp ${UPLOAD}/${LATEST_FILE} ${GCS_LOCATION} | |||
|
|
|||
| .PHONY: s3-publish-ci | |||
| s3-publish-ci: VERSION := ${KOPS_CI_VERSION}+${GITSHA} | |||
| s3-publish-ci: version-dist-ci | |||
There was a problem hiding this comment.
We do also have hack/upload, which might make this easier?
| cmd.SetDir(b.KopsRoot) | ||
| exec.InheritOutput(cmd) | ||
| if err := cmd.Run(); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // Get the full path (including subdirectory) that we uploaded to | ||
| // It is written by gcs-publish-ci to .build/upload/latest-ci.txt | ||
| // It is written by the *-publish-ci make tasks to .build/upload/latest-ci.txt |
There was a problem hiding this comment.
It might be nice to spell out the two tasks here (assuming we can't combine them), to make it more explicit and to help with searching...
|
We do need to ship this to fix the AWS presubmits publishing to the k8s-staging-kops bucket. We carried over that practice when the jobs were migrated to the community cluster. |
Ref: #16637 kubernetes/k8s.io#5127 kubernetes/k8s.io#2625
More context in kubernetes/k8s.io#6950 (comment)