Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different healthcheck port for AWS CSI controller #16909

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Oct 18, 2024

This avoids port conflicts when both the deployment (controller) and daemonset (agent) run as hostNetwork

Example:

https://storage.googleapis.com/kubernetes-ci-logs/logs/e2e-kops-aws-upgrade-k127-ko130-to-k128-kolatest-many-addons/1846558413924864000/artifacts/cluster-info/kube-system/events.yaml

- apiVersion: v1
  count: 13
  eventTime: null
  firstTimestamp: "2024-10-16T14:42:36Z"
  involvedObject:
    apiVersion: v1
    kind: Pod
    name: ebs-csi-controller-6c444dc485-8zlmm
    namespace: kube-system
    resourceVersion: "5101"
    uid: 49871d0b-efec-4aff-8fba-158f0deecc5d
  kind: Event
  lastTimestamp: "2024-10-16T14:50:45Z"
  message: '0/15 nodes are available: 12 node(s) didn''t match Pod''s node affinity/selector,
    3 node(s) didn''t have free ports for the requested pod ports. preemption: 0/15
    nodes are available: 12 Preemption is not helpful for scheduling, 3 No preemption
    victims found for incoming pod..'
  metadata:
    creationTimestamp: "2024-10-16T14:42:36Z"
    name: ebs-csi-controller-6c444dc485-8zlmm.17fef5f8db9d27c1
    namespace: kube-system
    resourceVersion: "2866"
    uid: d6650adf-9a99-45dc-8065-e696a0583a5b
  reason: FailedScheduling
  reportingComponent: ""
  reportingInstance: ""
  source:
    component: default-scheduler
  type: Warning

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 458758e into kubernetes:master Oct 19, 2024
24 of 25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 19, 2024
k8s-ci-robot added a commit that referenced this pull request Oct 19, 2024
…09-origin-release-1.30

Automated cherry pick of #16909: Use a different healthcheck port for AWS CSI controller
@mwiede
Copy link
Contributor

mwiede commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants