Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from glog to klog #115

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Switch from glog to klog #115

merged 1 commit into from
Nov 6, 2018

Conversation

dims
Copy link
Member

@dims dims commented Nov 4, 2018

Change-Id: Ie5d0f09425c945da9bf24474a212adf3148daf6f

@dims
Switch from glog to klog
2011ec3 
Change-Id: Ie5d0f09425c945da9bf24474a212adf3148daf6f
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2018
@dims
Copy link
Member Author

dims commented Nov 4, 2018

related to kubernetes/kubernetes#70264

@dims
Copy link
Member Author

dims commented Nov 5, 2018

/assign @lavalamp
/assign @mbohlool

@dims
Copy link
Member Author

dims commented Nov 6, 2018

/assign @seans3

@seans3
Copy link
Contributor

seans3 commented Nov 6, 2018

/lgtm

I'll let Daniel and/or Mehdy approve.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
@lavalamp
Copy link
Member

lavalamp commented Nov 6, 2018

/approve

Honestly there's no good reason to use glog/klog here, we should just remove the dep completely.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit a9a1621 into kubernetes:master Nov 6, 2018
@roycaihw roycaihw mentioned this pull request Nov 10, 2018
Closed
@Dean-Coakley Dean-Coakley mentioned this pull request Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@lavalamp lavalamp

@mbohlool mbohlool

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dims @seans3 @lavalamp @k8s-ci-robot @mbohlool