Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s.io/kube-openapi:upgrade k8s.io/klog to v2 #192

Merged
merged 1 commit into from
Apr 13, 2020
Merged

k8s.io/kube-openapi:upgrade k8s.io/klog to v2 #192

merged 1 commit into from
Apr 13, 2020

Conversation

tanjunchen
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mbohlool
You can assign the PR to them by writing /assign @mbohlool in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanjunchen
Copy link
Member Author

/assign @mbohlool

@@ -27,7 +27,8 @@ require (
golang.org/x/tools v0.0.0-20181011042414-1f849cf54d09 // indirect
gopkg.in/yaml.v2 v2.2.2
k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6
k8s.io/klog v0.0.0-20181102134211-b9b56d5dfc92
k8s.io/klog v1.0.0 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to remove v1?
it will reproduce again after running go mod tidy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to install github.com/KyleBanks/depth/cmd/depth but this seems to work:

> for dir in $(go list ./...); do depth -explain k8s.io/klog "$dir"; done
k8s.io/kube-openapi/cmd/openapi-gen -> k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/gengo/parser -> k8s.io/klog
k8s.io/kube-openapi/cmd/openapi-gen -> k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/klog
k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/gengo/parser -> k8s.io/klog
k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/klog
k8s.io/kube-openapi/pkg/generators -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/gengo/parser -> k8s.io/klog
k8s.io/kube-openapi/pkg/generators -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/klog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjunchen @apelisse i filed #196 with this commit and another commit pulling in newer gengo which uses klog v2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure . Thanks

go.mod Outdated
@@ -27,7 +27,8 @@ require (
golang.org/x/tools v0.0.0-20181011042414-1f849cf54d09 // indirect
gopkg.in/yaml.v2 v2.2.2
k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6
k8s.io/klog v0.0.0-20181102134211-b9b56d5dfc92
k8s.io/klog v1.0.0 // indirect
k8s.io/klog/v2 v2.0.0-rc.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to v2.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dims
Copy link
Member

dims commented Apr 13, 2020

/assign @sttts @lavalamp

@k8s-ci-robot k8s-ci-robot merged commit 690f563 into kubernetes:master Apr 13, 2020
@tanjunchen tanjunchen deleted the patch-01 branch April 14, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants