-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s.io/kube-openapi:upgrade k8s.io/klog to v2 #192
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @mbohlool |
@@ -27,7 +27,8 @@ require ( | |||
golang.org/x/tools v0.0.0-20181011042414-1f849cf54d09 // indirect | |||
gopkg.in/yaml.v2 v2.2.2 | |||
k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6 | |||
k8s.io/klog v0.0.0-20181102134211-b9b56d5dfc92 | |||
k8s.io/klog v1.0.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to remove v1?
it will reproduce again after running go mod tidy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to install github.com/KyleBanks/depth/cmd/depth
but this seems to work:
> for dir in $(go list ./...); do depth -explain k8s.io/klog "$dir"; done
k8s.io/kube-openapi/cmd/openapi-gen -> k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/gengo/parser -> k8s.io/klog
k8s.io/kube-openapi/cmd/openapi-gen -> k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/klog
k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/gengo/parser -> k8s.io/klog
k8s.io/kube-openapi/cmd/openapi-gen/args -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/klog
k8s.io/kube-openapi/pkg/generators -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/gengo/parser -> k8s.io/klog
k8s.io/kube-openapi/pkg/generators -> k8s.io/gengo/args -> k8s.io/gengo/generator -> k8s.io/klog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanjunchen @apelisse i filed #196 with this commit and another commit pulling in newer gengo which uses klog v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure . Thanks
go.mod
Outdated
@@ -27,7 +27,8 @@ require ( | |||
golang.org/x/tools v0.0.0-20181011042414-1f849cf54d09 // indirect | |||
gopkg.in/yaml.v2 v2.2.2 | |||
k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6 | |||
k8s.io/klog v0.0.0-20181102134211-b9b56d5dfc92 | |||
k8s.io/klog v1.0.0 // indirect | |||
k8s.io/klog/v2 v2.0.0-rc.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to v2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
ref:kubernetes/kubernetes#89961