Adds support for Symbol references in defaults #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/cc @apelisse |
79 tasks
apelisse
reviewed
Aug 21, 2023
alexzielenski
force-pushed
the
symbol-references
branch
4 times, most recently
from
9d24c3a
to
0db7937
Compare
refactor openapi test to return import lines add symbol reference test
alexzielenski
force-pushed
the
symbol-references
branch
from
0db7937
to
3b85353
Compare
apelisse
reviewed
Aug 29, 2023
|
added integration test, removed change to |
apelisse
reviewed
Aug 31, 2023
Comment on lines
+673
to
+692
| }, | ||
| "defaultedAliasSymbolReference": { | ||
| "type": "string", | ||
| "default": "SymbolConstant" | ||
| }, | ||
| "externalSymbolReference": { | ||
| "type": "string", | ||
| "default": "apple" | ||
| }, | ||
| "fullyQualifiedSymbolReference": { | ||
| "type": "string", | ||
| "default": "SymbolConstant" | ||
| }, | ||
| "localSymbolReference": { | ||
| "type": "string", | ||
| "default": "SymbolConstant" | ||
| }, | ||
| "pointerConversionSymbolReference": { | ||
| "type": "string", | ||
| "default": "apple" |
There was a problem hiding this comment.
Very cool to have the end-to-end test show that we end-up with the properly resolved values injected in the openapi! (big belated thanks to @seans3 for having written the test that makes the end-to-end possible).
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@thockin !! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gengo's Defaulter-gen has support for symbol references to be used as defaults in the form
+default=ref(package/of/symbol.Name)This PR exposes defaults declared as symbols into the OpenAPI
depends on kubernetes/gengo#247