Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some typo fix #44

Merged
merged 4 commits into from
Apr 3, 2018
Merged

Some typo fix #44

merged 4 commits into from
Apr 3, 2018

Conversation

AdamDang
Copy link
Contributor

@AdamDang AdamDang commented Apr 3, 2018

all used definition->all used definitions
to it's definition->to its definition
OpenAPIDefinitions->GetOpenAPIDefinitions
to provides->to provide

@AdamDang
Typo fix "definition"->"definitions"
4191e6a 
line 162: "all used definition in the provided spec" .
line 175: "all definition used by it "
 "definitions" should be used there.
@AdamDang
Update common.go
73925fa
@AdamDang
Update handler.go
2f292dc
@AdamDang
Update openapi.go
94b99db
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2018
@mbohlool mbohlool merged commit cd03089 into kubernetes:master Apr 3, 2018
@mbohlool
Copy link
Contributor

mbohlool commented Apr 3, 2018

Thanks for the contribution.

sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
@casualjim
Merge pull request kubernetes#44 from hypnoglow/43-relative-base-checks
aa90e7c 
Consistently check if RelativeBase is empty
sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
@casualjim
Merge pull request kubernetes#44 from mrostecki/deepcopy
dd2bd34 
Add DeepCopy and DeepCopyInto methods to all types
sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
@vadorovsky
Fix typos in comments to DeepCopyInto methods
2ce5189 
Follow-up to kubernetes#44.

Fixes: 13e5106 ("Add DeepCopy and DeepCopyInto methods to all
types")

Signed-off-by: Michal Rostecki <mrostecki@suse.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamDang @mbohlool @k8s-ci-robot