Sort map keys for deterministic testing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign apelisse |
|
/assign seans3 |
|
/assign mbohlool |
apelisse
approved these changes
Apr 3, 2018
| @@ -440,7 +452,7 @@ func (g openAPITypeWriter) generateExtensions(CommentLines []string) error { | |||
| } | |||
| } | |||
| // Next, generate extensions from "tags". | |||
| for tagKey := range tagToExtension { | |||
| for _, tagKey := range sortedMapKeys(tagToExtension) { | |||
There was a problem hiding this comment.
This is going to sort by tag, not extension.
I'm not trying to make a point, I'm just making sure it's obvious :-)
|
@mbohlool Can you please merge that? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sttts
pushed a commit
to sttts/kube-openapi
that referenced
this pull request
Nov 5, 2020
Fixes kubernetes#45 Signed-off-by: Igor Zibarev <zibarev.i@gmail.com>
sttts
pushed a commit
to sttts/kube-openapi
that referenced
this pull request
Nov 5, 2020
Fix typos in comments to DeepCopyInto methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the map keys to ensure deterministic testing.
Fixes possible flaky test.