Bump all Go dependencies #489
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
Looks like a type change in gengo: kubernetes/gengo@2a31dd7. |
|
Reverting gengo so we can update it in a separate PR |
lucacome
force-pushed
the
bump-deps
branch
3 times, most recently
from
27130d1
to
c19370e
Compare
Signed-off-by: Luca Comellini <luca.com@gmail.com>
|
@Jefftree can we merge this? |
|
hey, sorry been super busy with code freeze. Would you mind opening a k/k PR just to make sure tests are passing? I can also do it later this week. |
|
Do you mean after these changes are merged? |
|
Before the changes are merged by creating a temp PR pinned to your kube-openapi update branch and verifying the tests have no problems
Created the test PR here: kubernetes/kubernetes#126362 |
|
oh I didn't know you could pin it like that, cool! |
|
tests look good! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, lucacome The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 | ||
| github.com/emicklei/go-restful/v3 v3.12.1 | ||
| github.com/go-openapi/jsonreference v0.21.0 | ||
| github.com/go-openapi/swag v0.23.0 |
There was a problem hiding this comment.
govalidator, go-restful, jsonreference need review before bumping, these impact kubernetes API surface and behavior
Bumps all the dependencies to the latest version available. Hopefully after this dependabot will start behaving...