-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump all Go dependencies #489
Conversation
Looks like a type change in gengo: kubernetes/gengo@2a31dd7. |
Reverting gengo so we can update it in a separate PR |
27130d1
to
c19370e
Compare
Signed-off-by: Luca Comellini <luca.com@gmail.com>
@Jefftree can we merge this? |
hey, sorry been super busy with code freeze. Would you mind opening a k/k PR just to make sure tests are passing? I can also do it later this week. |
Do you mean after these changes are merged? |
Before the changes are merged by creating a temp PR pinned to your kube-openapi update branch and verifying the tests have no problems
Created the test PR here: kubernetes/kubernetes#126362 |
oh I didn't know you could pin it like that, cool! |
tests look good! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, lucacome The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 | ||
github.com/emicklei/go-restful/v3 v3.12.1 | ||
github.com/go-openapi/jsonreference v0.21.0 | ||
github.com/go-openapi/swag v0.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
govalidator, go-restful, jsonreference need review before bumping, these impact kubernetes API surface and behavior
Bumps all the dependencies to the latest version available. Hopefully after this dependabot will start behaving...