Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch go-json-experiment json to pass tests on go1.22 #503

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Aug 16, 2024

Per comment #501 (comment) and #501 (comment).

Fixes #501

This is manual patch to include the test fix from go-json-experiment/json@c2a874a. We cannot directly fast forward to that commit because it would increase our minimum supported go version to 1.21.

Tested manually via go test

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2024
@Jefftree
Copy link
Member Author

cc @jpbetz @liggitt @dsnet

@liggitt
Copy link
Member

liggitt commented Aug 16, 2024

make sure the passes on both the current minimum version of go for this repo (go 1.20) and on go 1.22 / 1.23

@liggitt
Copy link
Member

liggitt commented Aug 16, 2024

nit: avoid mentioning the other repo / commit sha in the commit message here or github may ping that commit with a comment every time this commit is picked / merged anywhere

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2024
@Jefftree Jefftree force-pushed the patch-experiment-json-test branch 3 times, most recently from e9f4eff to 1d27184 Compare August 16, 2024 21:22
@Jefftree
Copy link
Member Author

Removed the commit referencing another commit sha and expanded the testing to test for all go versions 1.20-1.23

@liggitt
Copy link
Member

liggitt commented Aug 16, 2024

/lgtm
/approve
/hold for CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Aug 16, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5732855 into kubernetes:master Aug 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-openapi tests fail at newer versions of go
3 participants