-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
downgrade govalidator, go-restful, jsonreference #508
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github.com/go-openapi/jsonreference v0.21.0 | ||
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a | ||
github.com/emicklei/go-restful/v3 v3.11.0 | ||
github.com/go-openapi/jsonreference v0.20.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is go mod tidy
happy with this? just want to make sure github.com/go-openapi/swag won't force up jsonreference or govalidator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, go-openapi/swag has no dependencies on either: https://github.com/go-openapi/swag/blob/master/go.mod
can you dry-run bumping k/k to the results of this to make sure this does what we need?
then make sure lint-dependencies and update-vendor are happy, and that govalidator didn't jump? |
/lgtm |
Per https://github.com/kubernetes/kube-openapi/pull/489/files#r1727377659, revert bumps to govalidator, go-restful, jsonreference
/assign @liggitt