Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade govalidator, go-restful, jsonreference #508

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Jefftree
Copy link
Member

Per https://github.com/kubernetes/kube-openapi/pull/489/files#r1727377659, revert bumps to govalidator, go-restful, jsonreference

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from apelisse August 22, 2024 15:49
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from seans3 August 22, 2024 15:49
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2024
github.com/go-openapi/jsonreference v0.21.0
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a
github.com/emicklei/go-restful/v3 v3.11.0
github.com/go-openapi/jsonreference v0.20.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is go mod tidy happy with this? just want to make sure github.com/go-openapi/swag won't force up jsonreference or govalidator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, go-openapi/swag has no dependencies on either: https://github.com/go-openapi/swag/blob/master/go.mod

@liggitt
Copy link
Member

liggitt commented Aug 22, 2024

can you dry-run bumping k/k to the results of this to make sure this does what we need?

hack/pin-dependency.sh github.com/kubernetes/kube-openapi=github.com/Jefftree/kube-openapi downgrade-dep

then make sure lint-dependencies and update-vendor are happy, and that govalidator didn't jump?

@liggitt
Copy link
Member

liggitt commented Aug 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 76de80e into kubernetes:master Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants