use our own fork of go-yaml

[aojea]

We have our own fork of go-yaml kubernetes-sigs/yaml#76 so we can simplify the dependency graph in kubernetes if we end the path in kubernetes-sigs/yaml

go mod why gopkg.in/yaml.v3
# gopkg.in/yaml.v3
k8s.io/apimachinery/pkg/util/managedfields
k8s.io/kube-openapi/pkg/util/pro

Ref kubernetes-sigs/structured-merge-diff#264

[aojea]

/assign @liggitt

[aojea]

this is coming from

go mod why gopkg.in/yaml.v3
# gopkg.in/yaml.v3
k8s.io/kube-openapi/cmd/openapi2smd
github.com/google/gnostic-models/openapiv2
gopkg.in/yaml.v3

[aojea]

I See, and the type is required, breaking this PR 😢

Error: pkg/util/proto/document_v3.go:291:31: cannot use s.GetDefault().ToRawInfo() (value of type *"gopkg.in/yaml.v3".Node) as *"sigs.k8s.io/yaml/goyaml.v3".Node value in argument to parseV3Interface

[aojea]

@jpbetz should we move github.com/google/gnostic-models/openapiv2 to our fork too?

[Jefftree]

Changing gnostic models into another repo will cause import breakage (kubernetes/kubernetes#118340 and https://kubernetes.slack.com/archives/C0EG7JC6T/p1687271483899979) because client-go depends on it, and I would prefer not doing unless absolutely necessary. seeking some opinions from others, cc: @liggitt @sttts

[aojea]

@Jefftree tried to mean, move the yaml imported version, not the package :)

[aojea]

/assign @jpbetz

[sttts]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sttts]

/retest

What do we do with the 1.20 CI failure?

[aojea]

it is legit, I will investigate more

[aojea]

@sttts it should be fixed now, I somehow added unnecessarely the dependency to test/integration/go.mod

[sttts]

/lgtm