Include feedback from review

kubernetes · Dec 17, 2022 · 07c2ab6 · 07c2ab6
1 parent e547f07
commit 07c2ab6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/app/server.go b/pkg/app/server.go
@@ -88,7 +88,6 @@ func RunKubeStateMetricsWrapper(ctx context.Context, opts *options.Options) erro
 // Any out-of-tree custom resource metrics could be registered by newing a registry factory
 // which implements customresource.RegistryFactory and pass all factories into this function.
 func RunKubeStateMetrics(ctx context.Context, opts *options.Options) error {
-	var factories []customresource.RegistryFactory
 	promLogger := promLogger{}
 
 	storeBuilder := store.NewBuilder()
@@ -152,12 +151,13 @@ func RunKubeStateMetrics(ctx context.Context, opts *options.Options) error {
 		return err
 	}
 
+	var factories []customresource.RegistryFactory
+
 	if config != nil {
-		crf, err := customresourcestate.FromConfig(config)
+		factories, err = customresourcestate.FromConfig(config)
 		if err != nil {
 			return fmt.Errorf("Parsing from Custom Resource State Metrics file failed: %v", err)
 		}
-		factories = append(factories, crf...)
 	}
 	storeBuilder.WithCustomResourceStoreFactories(factories...)
 
@@ -173,7 +173,7 @@ func RunKubeStateMetrics(ctx context.Context, opts *options.Options) error {
 
 	}
 
-	var resources []string
+	resources := make([]string, len(factories))
 
 	for _, factory := range factories {
 		resources = append(resources, factory.Name())