Guard owner.controller dereference (it can be nil)

kubernetes · Aug 24, 2017 · 17aadf3 · 17aadf3
1 parent 259497e
commit 17aadf3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/collectors/pod.go b/collectors/pod.go
@@ -276,7 +276,11 @@ func (pc *podCollector) collectPod(ch chan<- prometheus.Metric, p v1.Pod) {
 		addGauge(descPodOwner, 1, "<none>", "<none>", "<none>")
 	} else {
 		for _, owner := range owners {
-			addGauge(descPodOwner, 1, owner.Kind, owner.Name, strconv.FormatBool(*owner.Controller))
+			if owner.Controller != nil {
+				addGauge(descPodOwner, 1, owner.Kind, owner.Name, strconv.FormatBool(*owner.Controller))
+			} else {
+				addGauge(descPodOwner, 1, owner.Kind, owner.Name, "false")
+			}
 		}
 	}