Merge pull request #728 from reetasingh/master

Adding unit test and fixing typo

pkg/options/types.go

@@ -113,7 +113,7 @@ func (c *CollectorSet) Type() string {
 	return "string"
 }
 
-// NamespaceList represents a list of namespaces to query forom.
+// NamespaceList represents a list of namespaces to query from.
 type NamespaceList []string
 
 func (n *NamespaceList) String() string {

pkg/options/types_test.go

@@ -61,3 +61,33 @@ func TestCollectorSetSet(t *testing.T) {
 		}
 	}
 }
+
+func TestNamespaceListSet(t *testing.T) {
+	tests := []struct {
+		Desc   string
+		Value  string
+		Wanted NamespaceList
+	}{
+		{
+			Desc:   "empty namespacelist",
+			Value:  "",
+			Wanted: NamespaceList{},
+		},
+		{
+			Desc:  "normal namespacelist",
+			Value: "default, kube-system",
+			Wanted: NamespaceList([]string{
+				"default",
+				"kube-system",
+			}),
+		},
+	}
+
+	for _, test := range tests {
+		ns := &NamespaceList{}
+		gotError := ns.Set(test.Value)
+		if gotError != nil || !reflect.DeepEqual(*ns, test.Wanted) {
+			t.Errorf("Test error for Desc: %s. Want: %+v. Got: %+v. Got Error: %v", test.Desc, test.Wanted, *ns, gotError)
+		}
+	}
+}

pkg/whiteblacklist/whiteblacklist_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package whiteblacklist
 
 import (
+	"regexp"
 	"testing"
 )
 
@@ -118,3 +119,46 @@ func TestExclude(t *testing.T) {
 		}
 	})
 }
+
+func TestStatus(t *testing.T) {
+	t.Run("status when whitelist has single item", func(t *testing.T) {
+		item1 := "item1"
+		whitelist, _ := New(map[string]struct{}{item1: {}}, map[string]struct{}{})
+		actualStatusString := whitelist.Status()
+		expectedStatusString := "whitelisting the following items: " + item1
+		if actualStatusString != expectedStatusString {
+			t.Errorf("expected status %q but got %q", expectedStatusString, actualStatusString)
+		}
+	})
+	t.Run("status when whitelist has multiple items", func(t *testing.T) {
+		item1 := "item1"
+		item2 := "item2"
+		whitelist, _ := New(map[string]struct{}{item1: {}, item2: {}}, map[string]struct{}{})
+		actualStatusString := whitelist.Status()
+		expectedRegexPattern := `^whitelisting the following items: (item1|item2), (item2|item1)$`
+		matched, _ := regexp.MatchString(expectedRegexPattern, actualStatusString)
+		if !matched {
+			t.Errorf("expected status %q but got %q", expectedRegexPattern, actualStatusString)
+		}
+	})
+	t.Run("status when blacklist has single item", func(t *testing.T) {
+		item1 := "not-empty"
+		blacklist, _ := New(map[string]struct{}{}, map[string]struct{}{item1: {}})
+		actualStatusString := blacklist.Status()
+		expectedStatusString := "blacklisting the following items: " + item1
+		if actualStatusString != expectedStatusString {
+			t.Errorf("expected status %q but got %q", expectedStatusString, actualStatusString)
+		}
+	})
+	t.Run("status when blacklist has multiple items", func(t *testing.T) {
+		item1 := "item1"
+		item2 := "item2"
+		blacklist, _ := New(map[string]struct{}{}, map[string]struct{}{item1: {}, item2: {}})
+		actualStatusString := blacklist.Status()
+		expectedRegexPattern := `^blacklisting the following items: (item1|item2), (item2|item1)$`
+		matched, _ := regexp.MatchString(expectedRegexPattern, actualStatusString)
+		if !matched {
+			t.Errorf("expected status %q but got %q", expectedRegexPattern, actualStatusString)
+		}
+	})
+}