Remove hostname

kubernetes · Aug 30, 2023 · 92f8173 · 92f8173
1 parent e47e783
commit 92f8173
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/internal/store/endpointslice.go b/internal/store/endpointslice.go
@@ -91,11 +91,6 @@ func endpointSliceMetricFamilies(allowAnnotationsList, allowLabelsList []string)
 							labelValues []string
 						)
 
-						if ep.Hostname != nil {
-							labelKeys = append(labelKeys, "hostname")
-							labelValues = append(labelValues, *ep.Hostname)
-						}
-
 						// Per Docs.
 						// This must contain at least one address but no more than
 						// 100. These are all assumed to be fungible and clients may choose to only

diff --git a/internal/store/endpointslice_test.go b/internal/store/endpointslice_test.go
@@ -153,7 +153,7 @@ func TestEndpointSliceStore(t *testing.T) {
 					# HELP kube_endpointslice_endpoints_hints Topology routing hints attached to endpoints
 					# TYPE kube_endpointslice_endpoints gauge
         			# TYPE kube_endpointslice_endpoints_hints gauge
-         			kube_endpointslice_endpoints_hints{address="10.0.0.1",endpointslice="test_endpointslice-endpoints",for_zone="zone1",hostname="host"} 1
+         			kube_endpointslice_endpoints_hints{address="10.0.0.1",endpointslice="test_endpointslice-endpoints",for_zone="zone1"} 1
         			kube_endpointslice_endpoints{address="10.0.0.1",endpoint_nodename="node",endpoint_zone="west",endpointslice="test_endpointslice-endpoints",hostname="host",ready="true",terminating="false"} 1
         			kube_endpointslice_endpoints{address="192.168.1.10",endpoint_nodename="node",endpoint_zone="west",endpointslice="test_endpointslice-endpoints",hostname="host",ready="true",terminating="false"} 1
 				  `,