Merge pull request #1956 from bjorand/version_flag

remove broken --version flag, replace by version command

docs/cli-arguments.md

@@ -75,7 +75,6 @@ Flags:
       --total-shards int                           The total number of shards. Sharding is disabled when total shards is set to 1. (default 1)
       --use-apiserver-cache                        Sets resourceVersion=0 for ListWatch requests, using cached resources from the apiserver instead of an etcd quorum read.
   -v, --v Level                                    number for the log level verbosity
-      --version                                    kube-state-metrics build version information
       --vmodule moduleSpec                         comma-separated list of pattern=N settings for file-filtered logging
 
 Use "kube-state-metrics [command] --help" for more information about a command.

pkg/options/options.go

@@ -55,7 +55,6 @@ type Options struct {
 	TelemetryPort            int             `yaml:"telemetry_port"`
 	TotalShards              int             `yaml:"total_shards"`
 	UseAPIServerCache        bool            `yaml:"use_api_server_cache"`
-	Version                  bool            `yaml:"version"`
 
 	Config string
 
@@ -123,7 +122,6 @@ func (o *Options) AddFlags(cmd *cobra.Command) {
 	o.cmd.Flags().BoolVar(&o.EnableGZIPEncoding, "enable-gzip-encoding", false, "Gzip responses when requested by clients via 'Accept-Encoding: gzip' header.")
 	o.cmd.Flags().BoolVarP(&o.Help, "help", "h", false, "Print Help text")
 	o.cmd.Flags().BoolVarP(&o.UseAPIServerCache, "use-apiserver-cache", "", false, "Sets resourceVersion=0 for ListWatch requests, using cached resources from the apiserver instead of an etcd quorum read.")
-	o.cmd.Flags().BoolVarP(&o.Version, "version", "", false, "kube-state-metrics build version information")
 	o.cmd.Flags().Int32Var(&o.Shard, "shard", int32(0), "The instances shard nominal (zero indexed) within the total number of shards. (default 0)")
 	o.cmd.Flags().IntVar(&o.Port, "port", 8080, `Port to expose metrics on.`)
 	o.cmd.Flags().IntVar(&o.TelemetryPort, "telemetry-port", 8081, `Port to expose kube-state-metrics self metrics on.`)