Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuntimeClass metrics #1274

Closed
tallclair opened this issue Oct 21, 2020 · 5 comments · Fixed by #1276
Closed

Add RuntimeClass metrics #1274

tallclair opened this issue Oct 21, 2020 · 5 comments · Fixed by #1276
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tallclair
Copy link
Member

We should add RuntimeClass metrics. Maybe as an additional label on kube_pod_info?

/cc @egernst @SergeyKanzhelev

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2020
@egernst
Copy link
Contributor

egernst commented Oct 21, 2020

Thanks @tallclair

I think we want something similar to #1053, but for runtimeclass itself.

@lilic
Copy link
Member

lilic commented Oct 22, 2020

@egernst @egernst can you please explain the feature request in a bit more details so we can evaluate if we want this added or not, thanks!

@egernst
Copy link
Contributor

egernst commented Oct 22, 2020

@lilic thanks. As a user I would like to verify that a given RuntimeClass handler is being utilized, and how it is behaving from a health perspective.

When combined with kube_pod_status_phase, end-users can use tools like Grafana to quickly assess how pods running with various runtimeclass handlers compare. This is very similar to what was done for PodOverhead: #1053

I would want to add something like a gauge with label key kube_pod_runtimeclass_handler, and label value the handler being used.

@lilic
Copy link
Member

lilic commented Oct 23, 2020

Thanks @egernst sounds good to me! Are you interested in contributing this, otherwise we can mark it as help wanted. Note we are in the release 2.0 cycle so might be some delay in getting PRs merged.

@egernst
Copy link
Contributor

egernst commented Oct 23, 2020

Is there a cutoff for 2.0? I saw alpha from earlier this month (thanks!).

In a perfect world, I would contribute this ASAP and it would be available in 2.0. Do you think this is feasible?

egernst added a commit to egernst/kube-state-metrics that referenced this issue Oct 23, 2020
Add a metric gauge to provide observability for the runtimeclass
used for running a pod.

Fixes: kubernetes#1274

Signed-off-by: Eric Ernst <eric_ernst@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants