You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why is this needed: --labels-metric-allow-list is inconsistent with --metric-allowlist and there might be a better name for it, that is more descriptive on what it's doing. Describe the solution you'd like
Use one way to write allowlist/allow-list in flags
Reorder --labels-metric to --metric-labels
Consider using passthrough or filter as with allowlist folks might wonder if there's a denylist as well.
This is how it could read:
--metric-labels-passthrough string Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (Example: '=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'
The text was updated successfully, but these errors were encountered:
…rough
This might be more clear on what the flag is doing. There were two ways
to spell allow-list / allowlist which it removes as well
Fixes: kubernetes#1421
This might be more clear on what the flag is doing. There were two ways
to spell allow-list / allowlist which it removes as well
Fixes: kubernetes#1421
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this issue
Mar 26, 2021
This might be more clear on what the flag is doing. There were two ways
to spell allow-list / allowlist which it removes as well
Fixes: kubernetes#1421
What would you like to be added:
Why is this needed:
--labels-metric-allow-list
is inconsistent with--metric-allowlist
and there might be a better name for it, that is more descriptive on what it's doing.Describe the solution you'd like
--labels-metric
to--metric-labels
passthrough
orfilter
as with allowlist folks might wonder if there's a denylist as well.This is how it could read:
The text was updated successfully, but these errors were encountered: