Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kubernetes dependencies to v1.21 version #1454

Closed
lilic opened this issue Apr 13, 2021 · 4 comments
Closed

Bump kubernetes dependencies to v1.21 version #1454

lilic opened this issue Apr 13, 2021 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lilic
Copy link
Member

lilic commented Apr 13, 2021

Couple of things to do:
@lilic lilic added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 13, 2021
@mrueg
Copy link
Member

mrueg commented Apr 16, 2021

Sounds interesting to test against multiple versions, will need to see how long it will extend CI time (assuming the spin up of the kind clusters is where we spent most time on)

@lilic
Copy link
Member Author

lilic commented Apr 16, 2021

We do this in kube-prometheus, https://github.com/prometheus-operator/kube-prometheus/blob/main/.github/workflows/ci.yaml#L55-L56 You can see how it is in this PR prometheus-operator/kube-prometheus#1094 for example:

ci / E2E tests (kindest/node:v1.19.0) (pull_request) Successful in 6m
ci / E2E tests (kindest/node:v1.20.0) (pull_request) Successful in 6m

@lilic lilic added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 16, 2021
@lilic lilic pinned this issue Apr 16, 2021
@mrueg mrueg mentioned this issue Apr 16, 2021
Merged
@dgrisonnet
Copy link
Member

I can take care of the Kubernetes dependencies bump.

@dgrisonnet dgrisonnet mentioned this issue Apr 20, 2021
Merged
@lilic
Copy link
Member Author

lilic commented Apr 28, 2021

Thank you both! 🎉

@lilic lilic closed this as completed Apr 28, 2021
@lilic lilic unpinned this issue Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrueg @lilic @dgrisonnet