-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Test against multiple versions of k8s at the same time #1457
Conversation
826c711
to
f38578d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thank you! 🎉
/lgtm
/hold in case any objections from other folks
Just a side note, if this PR is merged as is, it will close #1454 because |
It might also be meaningful to update the compatibility matrix as part of this effort since it verifies that kube-state-metrics is compatible with Kubernetes |
f38578d
to
3aacffd
Compare
b042c71
to
bb0a320
Compare
bb0a320
to
5711402
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mrueg, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Thanks @mrueg ! |
What this PR does / why we need it:
We support multiple versions of k8s, let's run e2e tests for all as suggested by @lilic
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):See #1454