e2e: Test against multiple versions of k8s at the same time #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
mrueg
changed the title
mrueg
force-pushed
the
e2e-multiple-versions
branch
6 times, most recently
from
826c711
to
f38578d
Compare
lilic
approved these changes
Apr 19, 2021
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
|
Just a side note, if this PR is merged as is, it will close #1454 because |
dgrisonnet
reviewed
Apr 20, 2021
|
It might also be meaningful to update the compatibility matrix as part of this effort since it verifies that kube-state-metrics is compatible with Kubernetes |
mrueg
force-pushed
the
e2e-multiple-versions
branch
from
f38578d
to
3aacffd
Compare
k8s-ci-robot
removed
the
lgtm
mrueg
force-pushed
the
e2e-multiple-versions
branch
3 times, most recently
from
b042c71
to
bb0a320
Compare
mrueg
force-pushed
the
e2e-multiple-versions
branch
from
bb0a320
to
5711402
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mrueg, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel Thanks @mrueg ! |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We support multiple versions of k8s, let's run e2e tests for all as suggested by @lilic
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):See #1454